Skip to content

[Merged by Bors] - chore: rename Data.Bitvec to Data.BitVec#8710

Closed
eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser/rename-bitvec
Closed

[Merged by Bors] - chore: rename Data.Bitvec to Data.BitVec#8710
eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser/rename-bitvec

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Nov 29, 2023

This matches the name of Std.BitVec.
Performing the rename was deliberately left out of #5920, to avoid creating a break in the git history.


Open in Gitpod

This matches the name of `Std.BitVec`.
It was deliberately left out of a previous PR to preserve the git history.
@eric-wieser eric-wieser added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Nov 29, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 29, 2023
@urkud
Copy link
Copy Markdown
Member

urkud commented Nov 30, 2023

Please mention PR no of the "previous PR" in the commit message. Otherwise LGTM. Thanks!
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 30, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Nov 30, 2023
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 30, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 30, 2023
This matches the name of `Std.BitVec`.
Performing the rename was deliberately left out of #5920, to avoid creating a break in the git history.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 30, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename Data.Bitvec to Data.BitVec [Merged by Bors] - chore: rename Data.Bitvec to Data.BitVec Nov 30, 2023
@mathlib-bors mathlib-bors bot closed this Nov 30, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/rename-bitvec branch November 30, 2023 09:46
awueth pushed a commit that referenced this pull request Dec 19, 2023
This matches the name of `Std.BitVec`.
Performing the rename was deliberately left out of #5920, to avoid creating a break in the git history.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants