[Merged by Bors] - chore: replace exact_mod_cast tactic with mod_cast elaborator where possible#8404
Conversation
exact_mod_cast tactic with mod_cast elaborator where possible
Contributor
|
Based on the PR description I was worried this was a large-scale change just for debugging, but it definitely looks like an improvement. I like the idea that in general bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
…re possible (#8404) We still have the `exact_mod_cast` tactic, used in a few places, which somehow (?) works a little bit harder to prevent the expected type influencing the elaboration of the term. I would like to get to the bottom of this, and it will be easier once the only usages of `exact_mod_cast` are the ones that don't work using the term elaborator by itself. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 19, 2023
…re possible (#8404) We still have the `exact_mod_cast` tactic, used in a few places, which somehow (?) works a little bit harder to prevent the expected type influencing the elaboration of the term. I would like to get to the bottom of this, and it will be easier once the only usages of `exact_mod_cast` are the ones that don't work using the term elaborator by itself. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
exact_mod_cast tactic with mod_cast elaborator where possibleexact_mod_cast tactic with mod_cast elaborator where possible
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
…re possible (#8404) We still have the `exact_mod_cast` tactic, used in a few places, which somehow (?) works a little bit harder to prevent the expected type influencing the elaboration of the term. I would like to get to the bottom of this, and it will be easier once the only usages of `exact_mod_cast` are the ones that don't work using the term elaborator by itself. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
…re possible (#8404) We still have the `exact_mod_cast` tactic, used in a few places, which somehow (?) works a little bit harder to prevent the expected type influencing the elaboration of the term. I would like to get to the bottom of this, and it will be easier once the only usages of `exact_mod_cast` are the ones that don't work using the term elaborator by itself. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still have the
exact_mod_casttactic, used in a few places, which somehow (?) works a little bit harder to prevent the expected type influencing the elaboration of the term. I would like to get to the bottom of this, and it will be easier once the only usages ofexact_mod_castare the ones that don't work using the term elaborator by itself.