[Merged by Bors] - feat: Eventual boundedness of neighborhoods#8009
Closed
YaelDillies wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - feat: Eventual boundedness of neighborhoods#8009YaelDillies wants to merge 5 commits intomasterfrom
YaelDillies wants to merge 5 commits intomasterfrom
Conversation
sgouezel
reviewed
Oct 30, 2023
Comment on lines
+134
to
+138
| refine ⟨fun x ↦ ?_⟩ | ||
| obtain ⟨a, ha⟩ := isBounded_ge_nhds x.1 | ||
| obtain ⟨b, hb⟩ := isBounded_ge_nhds x.2 | ||
| rw [← @Prod.mk.eta _ _ x, nhds_prod_eq] | ||
| exact ⟨(a, b), ha.prod_mk hb⟩ |
Contributor
There was a problem hiding this comment.
instead of copying the proof, you can deduce it from the other one by order-dual arguments, with something like
Suggested change
| refine ⟨fun x ↦ ?_⟩ | |
| obtain ⟨a, ha⟩ := isBounded_ge_nhds x.1 | |
| obtain ⟨b, hb⟩ := isBounded_ge_nhds x.2 | |
| rw [← @Prod.mk.eta _ _ x, nhds_prod_eq] | |
| exact ⟨(a, b), ha.prod_mk hb⟩ | |
| ⟨(instBoundedLENhdsClassProd (α := αᵒᵈ) (β := βᵒᵈ)).isBounded_le_nhds⟩ |
(if you have named the instance above). Same thing for the next instance.
Member
There was a problem hiding this comment.
Since this is a forward-port PR, I think this is best left to a follow-up. The ideal place for this comment would have been leanprover-community/mathlib3#18629!
eric-wieser
reviewed
Nov 1, 2023
Member
|
This looks like a faithful forward-port, so bors merge Please open a follow-up PR to address @sgouezel's concerns. |
|
Canceled. |
Member
|
bors merge |
1 task
bors bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Forward port leanprover-community/mathlib3#18629 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 13, 2025
#15420) This is a partial attempt at #15410, porting [#8009](leanprover-community/mathlib3#8009) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Jun 15, 2025
leanprover-community#15420) This is a partial attempt at leanprover-community#15410, porting [leanprover-community#8009](leanprover-community/mathlib3#8009) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Jun 15, 2025
leanprover-community#15420) This is a partial attempt at leanprover-community#15410, porting [leanprover-community#8009](leanprover-community/mathlib3#8009) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Rida-Hamadani
pushed a commit
to Rida-Hamadani/mathlib4
that referenced
this pull request
Jun 24, 2025
leanprover-community#15420) This is a partial attempt at leanprover-community#15410, porting [leanprover-community#8009](leanprover-community/mathlib3#8009) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
callesonne
pushed a commit
to callesonne/mathlib4
that referenced
this pull request
Jul 24, 2025
leanprover-community#15420) This is a partial attempt at leanprover-community#15410, porting [leanprover-community#8009](leanprover-community/mathlib3#8009) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port leanprover-community/mathlib3#18629