[Merged by Bors] - chore: ofNat lemmas for Complex.normSq and abs#7975
Closed
[Merged by Bors] - chore: ofNat lemmas for Complex.normSq and abs#7975
Conversation
626ecf7 to
45f9120
Compare
eric-wieser
reviewed
Oct 27, 2023
eric-wieser
reviewed
Oct 27, 2023
eric-wieser
reviewed
Oct 27, 2023
eric-wieser
approved these changes
Oct 27, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Just the long line to fix.
|
✌️ timotree3 can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Oct 27, 2023
Collaborator
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Having `_ofNat` lemmas is important for confluence given that for both `normSq` and `abs`, the `_ofReal` lemma is `@[simp]` and so is `ofReal_ofNat`. We already have lemmas for 0 and 1 from the bundled classes for both functions, so I'm only adding lemmas for the `AtLeastTwo` case here.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Having `_ofNat` lemmas is important for confluence given that for both `normSq` and `abs`, the `_ofReal` lemma is `@[simp]` and so is `ofReal_ofNat`. We already have lemmas for 0 and 1 from the bundled classes for both functions, so I'm only adding lemmas for the `AtLeastTwo` case here.
|
Build failed (retrying...): |
Member
|
bors r- bors d+ |
|
✌️ timotree3 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Canceled. |
Collaborator
Author
|
bors r+ Sorry for causing bors to repeatedly retry. I thought it was safe to |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
Having `_ofNat` lemmas is important for confluence given that for both `normSq` and `abs`, the `_ofReal` lemma is `@[simp]` and so is `ofReal_ofNat`. We already have lemmas for 0 and 1 from the bundled classes for both functions, so I'm only adding lemmas for the `AtLeastTwo` case here.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
grunweg
pushed a commit
that referenced
this pull request
Nov 1, 2023
Having `_ofNat` lemmas is important for confluence given that for both `normSq` and `abs`, the `_ofReal` lemma is `@[simp]` and so is `ofReal_ofNat`. We already have lemmas for 0 and 1 from the bundled classes for both functions, so I'm only adding lemmas for the `AtLeastTwo` case here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having
_ofNatlemmas is important for confluence given that for bothnormSqandabs, the_ofReallemma is@[simp]and so isofReal_ofNat. We already have lemmas for 0 and 1 from the bundled classes for both functions, so I'm only adding lemmas for theAtLeastTwocase here.