Skip to content

[Merged by Bors] - chore: allow more heartbeats in Algebra/Jordan/Basic#7952

Closed
kim-em wants to merge 2 commits intomasterfrom
jordan_heartbeat
Closed

[Merged by Bors] - chore: allow more heartbeats in Algebra/Jordan/Basic#7952
kim-em wants to merge 2 commits intomasterfrom
jordan_heartbeat

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Oct 26, 2023

This was already extremely close to the limit, and becomes a tiny bit over on nightly-2023-10-26 (no significant overall change, see discussion at leanprover/lean4#2714 (comment)).


Open in Gitpod

@kim-em kim-em added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Oct 26, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Oct 26, 2023
@kim-em kim-em added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 26, 2023
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

A constrain_heartbeats NNNNNN in command that automatically ensures that NNNNNN is within 50% of the original would be helpful to avoid us having to deal with this type of thing so often.

@bors
Copy link
Copy Markdown

bors bot commented Oct 26, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Oct 26, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Oct 26, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 26, 2023
bors bot pushed a commit that referenced this pull request Oct 26, 2023
This was already extremely close to the limit, and becomes a tiny bit over on `nightly-2023-10-26` (no significant overall change, see discussion at leanprover/lean4#2714 (comment)).





Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Oct 27, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: allow more heartbeats in Algebra/Jordan/Basic [Merged by Bors] - chore: allow more heartbeats in Algebra/Jordan/Basic Oct 27, 2023
@bors bors bot closed this Oct 27, 2023
@bors bors bot deleted the jordan_heartbeat branch October 27, 2023 00:15
grunweg pushed a commit that referenced this pull request Nov 1, 2023
This was already extremely close to the limit, and becomes a tiny bit over on `nightly-2023-10-26` (no significant overall change, see discussion at leanprover/lean4#2714 (comment)).





Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants