[Merged by Bors] - chore(Algebra/Group/TypeTags): lemmas about pow and smul#7862
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/Group/TypeTags): lemmas about pow and smul#7862eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser wants to merge 3 commits intomasterfrom
Conversation
2 tasks
Contributor
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
Half of these lemmas already existed, but were a long way from the definition that define the operators. For the ones that did exist, the `#align`s have been kept. The new lemmas are all `@[simp]` since that matches the corresponding `add`/`mul` lemmas. This makes some lemmas about `Int` and `Nat` not simp-normal any more (they disagree on commutativity), but that doesn't seem to matter.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Half of these lemmas already existed, but were a long way from the definition that define the operators.
For the ones that did exist, the
#aligns have been kept.The new lemmas are all
@[simp]since that matches the correspondingadd/mullemmas.This makes some lemmas about
IntandNatnot simp-normal any more (they disagree on commutativity), but that doesn't seem to matter.Marking this as "easy" since every lemma isNevemind, there are simpNF considerations.rfl.