Skip to content

[Merged by Bors] - feat: port Order.WithBot#777

Closed
ChrisHughes24 wants to merge 6 commits intomasterfrom
order_with_bot
Closed

[Merged by Bors] - feat: port Order.WithBot#777
ChrisHughes24 wants to merge 6 commits intomasterfrom
order_with_bot

Conversation

@ChrisHughes24
Copy link
Copy Markdown
Member

@ChrisHughes24 ChrisHughes24 commented Nov 29, 2022

SHA: 1fc36cc9c8264e6e81253f88be7fb2cb6c92d76a

Finished port

The main change was introducing WithBot.some and WithTop.some and defining the coercion as WithBot.some instead of Option.some to avoid elaboration issues with using Option.some.

@ChrisHughes24 ChrisHughes24 added awaiting-review mathlib-port This is a port of a theory file from mathlib. labels Nov 29, 2022
@digama0 digama0 changed the title feat port:(Order/WithBot) feat: port Order.WithBot Nov 29, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 29, 2022

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 29, 2022
bors bot pushed a commit that referenced this pull request Nov 29, 2022
SHA: 4674d16c9f219334f07b9220ea5f315838bbb573

Finished port

The main change was introducing `WithBot.some` and `WithTop.some` and defining the coercion as `WithBot.some` instead of `Option.some` to avoid elaboration issues with using `Option.some`.
@bors
Copy link
Copy Markdown

bors bot commented Nov 29, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 29, 2022
SHA: 4674d16c9f219334f07b9220ea5f315838bbb573

Finished port

The main change was introducing `WithBot.some` and `WithTop.some` and defining the coercion as `WithBot.some` instead of `Option.some` to avoid elaboration issues with using `Option.some`.
@bors
Copy link
Copy Markdown

bors bot commented Nov 29, 2022

Build failed:

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 29, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 29, 2022
SHA: 4674d16c9f219334f07b9220ea5f315838bbb573

Finished port

The main change was introducing `WithBot.some` and `WithTop.some` and defining the coercion as `WithBot.some` instead of `Option.some` to avoid elaboration issues with using `Option.some`.
@bors
Copy link
Copy Markdown

bors bot commented Nov 29, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.WithBot [Merged by Bors] - feat: port Order.WithBot Nov 29, 2022
@bors bors bot closed this Nov 29, 2022
@bors bors bot deleted the order_with_bot branch November 29, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants