[Merged by Bors] - feat(LinearAlgebra/Matrix): transvection matrix is block triangular#7765
Closed
shuxuezhuyi wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - feat(LinearAlgebra/Matrix): transvection matrix is block triangular#7765shuxuezhuyi wants to merge 5 commits intomasterfrom
shuxuezhuyi wants to merge 5 commits intomasterfrom
Conversation
2 tasks
eric-wieser
reviewed
Oct 19, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
Thanks for this! Unfortunately there's a fair amount of overlap with existing results in mathlib across this chain of PRs, but this one in particular has some useful results that look new.
Contributor
Author
|
I'm sorry that I didn't search mathlib carefully enough. Now I've rewritten the code. |
eric-wieser
reviewed
Oct 19, 2023
eric-wieser
reviewed
Oct 19, 2023
eric-wieser
reviewed
Oct 19, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
approved these changes
Oct 19, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Thanks! Sorry that you ended up wasting some time writing your own version of transvection, but hopefully it was a good learning experience even if it ultimately wasn't PR-able!
|
✌️ shuxuezhuyi can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
bors merge |
bors Bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…7765) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed (retrying...): |
bors Bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
…7765) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Eric Wieser wieser.eric@gmail.com