[Merged by Bors] - chore(Topology/Compactness/SigmaCompact): rename type variables#7730
Closed
[Merged by Bors] - chore(Topology/Compactness/SigmaCompact): rename type variables#7730
Conversation
Previously, the names X, Y and Z were only used to refer to topological spaces.
This was referenced Oct 17, 2023
Member
|
Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause |
Contributor
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Greek letters for topological spaces are outdated, use letters X, Y, Z instead. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
grunweg
added a commit
that referenced
this pull request
Nov 1, 2023
Greek letters for topological spaces are outdated, use letters X, Y, Z instead. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
fgdorais
pushed a commit
that referenced
this pull request
Nov 1, 2023
Greek letters for topological spaces are outdated, use letters X, Y, Z instead. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893). Co-authored-by: Mario Carneiro <di.gama@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greek letters for topological spaces are outdated, use letters X, Y, Z instead.
Zulip discussion.
I'm following my checklist here.
Best reviewed commit by commit. (Before this change, the names X, Y or Z were sometimes (but inconsistently) used for topological spaces. This change makes things consistent.)
Rebase of #7639 on top of latest master.