Skip to content

[Merged by Bors] - fix: to_additive generates equation lemmas for target#767

Closed
fpvandoorn wants to merge 3 commits intomasterfrom
to_additive_eq_lemmas
Closed

[Merged by Bors] - fix: to_additive generates equation lemmas for target#767
fpvandoorn wants to merge 3 commits intomasterfrom
to_additive_eq_lemmas

Conversation

@fpvandoorn
Copy link
Copy Markdown
Member

@fpvandoorn fpvandoorn commented Nov 28, 2022

  • Also copy attributes for equation lemmas
  • Add a comment why we generate equation lemmas for non-recursive definitions.
  • This will allow us to doubly additivize a declaration (e.g. Pow -> SMul -> VAdd)

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 28, 2022

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 28, 2022
bors bot pushed a commit that referenced this pull request Nov 28, 2022
* Also copy attributes for equation lemmas
* Add a comment why we generate equation lemmas for non-recursive definitions.
* This will allow us to doubly additivize a declaration (e.g. `Pow -> SMul -> VAdd`)
@bors
Copy link
Copy Markdown

bors bot commented Nov 28, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix: to_additive generates equation lemmas for target [Merged by Bors] - fix: to_additive generates equation lemmas for target Nov 28, 2022
@bors bors bot closed this Nov 28, 2022
@bors bors bot deleted the to_additive_eq_lemmas branch November 28, 2022 15:29
rosborn added a commit that referenced this pull request Nov 29, 2022
* master: (26 commits)
  docs (Order.BoundedOrder): fix typos (#775)
  feat: port Algebra.Order.Monoid.Cancel.Defs (#774)
  feat: port Order.Disjoint (#773)
  feat: port linarith (#526)
  feat: port Algebra.Order.Monoid.Defs (#771)
  feat: port control.functor (#612)
  feat(Algebra/GroupWithZero/Commute): port file (#762)
  feat: port Logic.Equiv.Option (#674)
  chore: fix todos in `to_additive` (#765)
  feat(Algebra/Order/Monoid/MinMax): port file (#763)
  fix: update context in recursive calls in split_ifs (#761)
  feat(Algebra/Regular/Basic): port file (#758)
  feat: port Order.BoundedOrder (#697)
  feat: port Data.Pi.Algebra (#564)
  feat: port Algebra.Hom.Embedding (#764)
  fix: to_additive generates equation lemmas for target (#767)
  fix: fix translation errors in various files (#716)
  fix: remove submodules (#766)
  feat(Algebra/Group/Commute): port file (#750)
  feat(Algebra/Ring/Commute): port file (#759)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants