[Merged by Bors] - feat(Data/Set): images of intervals under Subtype.val#7653
Closed
[Merged by Bors] - feat(Data/Set): images of intervals under Subtype.val#7653
Subtype.val#7653Conversation
Add `simp` lemmas for images of intervals in other intervals under `Subtype.val`.
7 tasks
Contributor
|
Thanks! |
bors bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
Add `simp` lemmas for images of intervals in other intervals under `Subtype.val`.
eric-wieser
reviewed
Oct 30, 2023
| image_subset_iff.mpr fun _ m => m | ||
|
|
||
| @[simp] | ||
| lemma image_subtype_val_Ici_Iic {a : α} (b : Ici a) : Subtype.val '' Iic b = Icc a b := |
Member
There was a problem hiding this comment.
To make these easier to read, can you make the coercion explicit?
Suggested change
| lemma image_subtype_val_Ici_Iic {a : α} (b : Ici a) : Subtype.val '' Iic b = Icc a b := | |
| lemma image_subtype_val_Ici_Iic {a : α} (b : Ici a) : Subtype.val '' Iic b = Icc a ↑b := |
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Subtype.valSubtype.val
grunweg
pushed a commit
that referenced
this pull request
Nov 1, 2023
Add `simp` lemmas for images of intervals in other intervals under `Subtype.val`.
fgdorais
pushed a commit
that referenced
this pull request
Nov 1, 2023
Add `simp` lemmas for images of intervals in other intervals under `Subtype.val`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
simplemmas for images of intervals in other intervalsunder
Subtype.val.I needed one of these lemmas in an ongoing project, so I added all of them.