Skip to content

[Merged by Bors] - chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables#7591

Closed
grunweg wants to merge 35 commits intomasterfrom
MR-rename-types2a
Closed

[Merged by Bors] - chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables#7591
grunweg wants to merge 35 commits intomasterfrom
MR-rename-types2a

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Oct 9, 2023

X, Y, Z are standard mathematical names for topological spaces.
As discussed on zulip, let us rename them.

As a drive-by commit, re-use the declared variables $\iota$, $s$ and $t$ (more) when stating theorems.


I'm following by checklist here.

@grunweg grunweg added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Oct 9, 2023
@eric-wieser
Copy link
Copy Markdown
Member

X, Y, Z are standard mathematical names for topological spaces.

I'm not sure if this is true in mathlib; I've seen greek letters in lots of places too. There is only one mention of topology in the style guide, and it uses [DiscreteTopology α]!

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 9, 2023

X, Y, Z are standard mathematical names for topological spaces.

I'm not sure if this is true in mathlib; I've seen greek letters in lots of places too. There is only one mention of topology in the style guide, and it uses [DiscreteTopology α]!

I agree that Greek letters are pervasive in topology files. In math textbooks, I've always seen X, Y, Z etc., though. Hence, my guess was that general topology files, being old enough, were written when Greek letter prevailed. (It's possible I'm wrong, though!)

As a case in point, I've looked at the first ten files in the Topology root folder: two use names X, Y, Z, the others use Greek letters --- but almost all of the latter have copyright years 2019 or earlier.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 9, 2023

I've asked on zulip.

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 11, 2023
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 12, 2023

awaiting-author

@github-actions github-actions bot added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Oct 12, 2023
@PatrickMassot
Copy link
Copy Markdown
Member

I'm sorry we haven't been quick enough to merge that one. Could you please try to fix the conflicts?

@grunweg grunweg changed the title chore(Topology/SubsetProperties): rename type variables chore(Topology/{Compactness/Compact}, Irreducibile}): rename type variables Nov 29, 2023
@grunweg grunweg added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 29, 2023
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 29, 2023

@PatrickMassot Updated; as soon as this passes CI, it should be ready for review.
The merge meant I had to basically re-do these changes; it might be easier to just review/skim all commits since the merge separately. (They're logically independent.)

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Nov 29, 2023
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 30, 2023
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 30, 2023

awaiting-review

@github-actions github-actions bot added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 30, 2023
@grunweg grunweg changed the title chore(Topology/{Compactness/Compact}, Irreducibile}): rename type variables chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables Nov 30, 2023
@PatrickMassot
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 30, 2023
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Nov 30, 2023

Thanks for the quick reviews, this time!

mathlib-bors bot pushed a commit that referenced this pull request Nov 30, 2023
…ables (#7591)

X, Y, Z are standard mathematical names for topological spaces.
As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, let us rename them.

As a drive-by commit, re-use the declared variables $\iota$, $s$ and $t$ (more) when stating theorems.



Co-authored-by: grunweg <grunweg@posteo.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Nov 30, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables [Merged by Bors] - chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables Nov 30, 2023
@mathlib-bors mathlib-bors bot closed this Nov 30, 2023
@mathlib-bors mathlib-bors bot deleted the MR-rename-types2a branch November 30, 2023 21:45
awueth pushed a commit that referenced this pull request Dec 19, 2023
…ables (#7591)

X, Y, Z are standard mathematical names for topological spaces.
As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, let us rename them.

As a drive-by commit, re-use the declared variables $\iota$, $s$ and $t$ (more) when stating theorems.



Co-authored-by: grunweg <grunweg@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants