[Merged by Bors] - chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables#7591
[Merged by Bors] - chore(Topology/{Compactness/Compact}, Irreducible}): rename type variables#7591
Conversation
I'm not sure if this is true in mathlib; I've seen greek letters in lots of places too. There is only one mention of topology in the style guide, and it uses |
I agree that Greek letters are pervasive in topology files. In math textbooks, I've always seen X, Y, Z etc., though. Hence, my guess was that general topology files, being old enough, were written when Greek letter prevailed. (It's possible I'm wrong, though!) As a case in point, I've looked at the first ten files in the Topology root folder: two use names X, Y, Z, the others use Greek letters --- but almost all of the latter have copyright years 2019 or earlier. |
|
I've asked on zulip. |
|
awaiting-author |
|
I'm sorry we haven't been quick enough to merge that one. Could you please try to fix the conflicts? |
|
@PatrickMassot Updated; as soon as this passes CI, it should be ready for review. |
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
|
awaiting-review |
|
bors merge |
|
Thanks for the quick reviews, this time! |
…ables (#7591) X, Y, Z are standard mathematical names for topological spaces. As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, let us rename them. As a drive-by commit, re-use the declared variables $\iota$, $s$ and $t$ (more) when stating theorems. Co-authored-by: grunweg <grunweg@posteo.de>
|
Pull request successfully merged into master. Build succeeded: |
…ables (#7591) X, Y, Z are standard mathematical names for topological spaces. As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, let us rename them. As a drive-by commit, re-use the declared variables $\iota$, $s$ and $t$ (more) when stating theorems. Co-authored-by: grunweg <grunweg@posteo.de>
X, Y, Z are standard mathematical names for topological spaces.
As discussed on zulip, let us rename them.
As a drive-by commit, re-use the declared variables$\iota$ , $s$ and $t$ (more) when stating theorems.
I'm following by checklist here.