Skip to content

[Merged by Bors] - doc: Clarify the use case of Function.extend#7547

Closed
YaelDillies wants to merge 5 commits intomasterfrom
function_extend_doc
Closed

[Merged by Bors] - doc: Clarify the use case of Function.extend#7547
YaelDillies wants to merge 5 commits intomasterfrom
function_extend_doc

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Oct 6, 2023

Confusion was recently expressed so as to how to use Function.extend. This is an attempt to clear it up.

Also fix the name of Injective.factorsThrough.


Open in Gitpod

Confusion was recently expressed so as to how to use `Function.extend`. This is an to clear it up.

Also fix the name of `Injective.factorsThrough`.
@YaelDillies YaelDillies added documentation Improvements or additions to documentation awaiting-review labels Oct 6, 2023
/-- `extend f g e'` extends a function `g : α → γ`
along a function `f : α → β` to a function `β → γ`,
by using the values of `g` on the range of `f`
and the values of an auxiliary function `e' : β → γ` elsewhere.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I quite liked the mnemonic of e for elsewhere

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I really didn't get that mnemonic. I used j for junk.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't really see how to restore that mnemonic.

Copy link
Copy Markdown
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Oct 16, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Oct 16, 2023
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
@YaelDillies
Copy link
Copy Markdown
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Oct 16, 2023
Confusion was recently expressed so as to how to use `Function.extend`. This is an attempt to clear it up.

Also fix the name of `Injective.factorsThrough`.
@bors
Copy link
Copy Markdown

bors bot commented Oct 16, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Oct 16, 2023
Confusion was recently expressed so as to how to use `Function.extend`. This is an attempt to clear it up.

Also fix the name of `Injective.factorsThrough`.
@bors
Copy link
Copy Markdown

bors bot commented Oct 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title doc: Clarify the use case of Function.extend [Merged by Bors] - doc: Clarify the use case of Function.extend Oct 16, 2023
@bors bors bot closed this Oct 16, 2023
@bors bors bot deleted the function_extend_doc branch October 16, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants