[Merged by Bors] - perf (LinearAlgebra.Quotient): direct inheritance for extended SMul classes#7459
Closed
mattrobball wants to merge 13 commits intomasterfrom
Closed
[Merged by Bors] - perf (LinearAlgebra.Quotient): direct inheritance for extended SMul classes#7459mattrobball wants to merge 13 commits intomasterfrom
mattrobball wants to merge 13 commits intomasterfrom
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit c4ec9a2. Benchmark Metric Change
===================================================================
+ ~Mathlib.Algebra.Category.ModuleCat.Abelian instructions -8.7%
+ ~Mathlib.Algebra.Category.ModuleCat.Limits instructions -25.5% |
Contributor
Author
|
Added TODO for #7432 |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 49fc6f9. Benchmark Metric Change
=========================================================================================
+ ~Mathlib.Algebra.Category.ModuleCat.Abelian instructions -8.7%
+ ~Mathlib.Algebra.Category.ModuleCat.Limits instructions -25.5%
- ~Mathlib.CategoryTheory.Limits.FilteredColimitCommutesFiniteLimit instructions 5.3% |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
…lasses (#7459) We replace the calls to `Function.Surjective.x` for constructing instances with a more direct inheritance pattern. Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com> Co-authored-by: Matthew Ballard <matt@mrb.email>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace the calls to
Function.Surjective.xfor constructing instances with a more direct inheritance pattern.