Skip to content

[Merged by Bors] - feat: Extra sups lemmas#7382

Closed
YaelDillies wants to merge 5 commits intomasterfrom
sup_closed_sups
Closed

[Merged by Bors] - feat: Extra sups lemmas#7382
YaelDillies wants to merge 5 commits intomasterfrom
sup_closed_sups

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor


Open in Gitpod

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
subset_sups_self.le.le_iff_eq.symm.trans sups_self_subset

lemma sep_sups_le (s t : Set α) (a : α) :
{b ∈ s ⊻ t | b ≤ a} = {b ∈ s | b ≤ a} ⊻ {b ∈ t | b ≤ a} := by ext; aesop
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to state this as (s ⊻ t) \inter Iic a = ...? Or is that less useful to you?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Finset version, I must use filter since my order isn't locally finite. For the Set version, I don't really mind, except that using sep is more consistent than intersecting with Iic a.

What do you think? (I don't think it's too important so I'll merge the PR as is, but I'll modify that file quite a lot in the next few weeks so I'm happy to change later)

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@bors
Copy link
Copy Markdown

bors bot commented Sep 27, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Sep 27, 2023
@YaelDillies
Copy link
Copy Markdown
Contributor Author

Thanks. That was quick!

bors merge

bors bot pushed a commit that referenced this pull request Sep 28, 2023
@bors
Copy link
Copy Markdown

bors bot commented Sep 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Extra sups lemmas [Merged by Bors] - feat: Extra sups lemmas Sep 28, 2023
@bors bors bot closed this Sep 28, 2023
@bors bors bot deleted the sup_closed_sups branch September 28, 2023 06:20
bors bot pushed a commit that referenced this pull request Nov 1, 2023
Match leanprover-community/mathlib3#18612.

The lemmas were already added in #7382, though a slight difference in the statement means that we need a new `decidableExistsAndFinsetCoe` instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-order Order theory

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants