[Merged by Bors] - chore: only four spaces for subsequent lines#7286
Closed
[Merged by Bors] - chore: only four spaces for subsequent lines#7286
Conversation
Collaborator
mo271
commented
Sep 21, 2023
changes occurances found by
^(lemma|theorem) .* :\n {4} +\S
regular expression
^(lemma|theorem) .* :\n {2}\S
regular expression:
^(lemma|theorem) .* :\n {3}\S
regular expression ^(lemma|theorem) .* :\n\S
Collaborator
Author
|
This fixes the findings of #7283 |
Collaborator
Author
|
From the style guide: "If the theorem statement requires multiple lines, indent the subsequent lines by 4 spaces." |
1 task
Contributor
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
alreadydone
reviewed
Sep 29, 2023
Comment on lines
+289
to
290
| ¬SeparatedNhds {x : ℝₗ × ℝₗ | x.1 + x.2 = 0 ∧ ∃ r : ℚ, ↑r = x.1} | ||
| {x : ℝₗ × ℝₗ | x.1 + x.2 = 0 ∧ Irrational (toReal x.1)} := by |
Contributor
There was a problem hiding this comment.
Personally I'd indent line 290 by two more spaces since it's an argument of SeparatedNhds so not "at the same level".
alreadydone
reviewed
Sep 29, 2023
Comment on lines
+193
to
+195
| -- Porting note : Lean can't see `Quot.mk Setoid.r x` is a `ColimitType F` even with type | ||
| -- annotation so use `Neg.neg (α := ColimitType F)` to tell Lean negation happens inside | ||
| -- `ColimitType F`. |
Contributor
There was a problem hiding this comment.
Do we want to force comments to be four-space indented as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.