Skip to content

[Merged by Bors] - feat: Independence of singletons#7251

Closed
YaelDillies wants to merge 14 commits intomasterfrom
independence_singleton
Closed

[Merged by Bors] - feat: Independence of singletons#7251
YaelDillies wants to merge 14 commits intomasterfrom
independence_singleton

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Sep 19, 2023

Port a bit of leanprover-community/mathlib3#18506, but it's mostly handmade.


Rémy, I tried understanding your new independence API but I still feel like I'm butchering your file.

From LeanCamCombi

Open in Gitpod

@YaelDillies YaelDillies added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-measure-probability Measure theory / Probability theory labels Sep 19, 2023
@RemyDegenne RemyDegenne self-assigned this Sep 26, 2023
@bors bors bot changed the base branch from generate_from_singleton to master September 26, 2023 13:13
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 26, 2023
@ghost
Copy link
Copy Markdown

ghost commented Sep 26, 2023

This PR/issue depends on:

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 26, 2023
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 26, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Sep 27, 2023
@RemyDegenne
Copy link
Copy Markdown
Contributor

RemyDegenne commented Oct 2, 2023

I will review this more thoroughly in the next two days, but right now I can say that it looks like many results could be generalized to independence with respect to a kernel and a measure (like most results about independence). For example, we could have, in Independence/Kernel.lean,

theorem iIndepSets_singleton_iff {s : ι → Set Ω} {_mΩ : MeasurableSpace Ω}
    {κ : kernel α Ω} {μ : Measure α} :
    iIndepSets (fun i ↦ {s i}) κ μ ↔
      ∀ S : Finset ι, ∀ᵐ a ∂μ, κ a (⋂ i ∈ S, s i) = ∏ i in S, κ a (s i) := by

I actually wrote a few of those results for #6098 because I wanted to deduce the conditional independence version. That was before I remembered that you had similar lemmas for independence.

If you don't want to generalize the various lemmas yourself, I can do it and push to this PR. Feel free to take from #6098 if you want to do it (I don't think everything is in there, but the example above is).

As for butchering "my" file, no worries: I think the API is far from perfect and I would love it if someone else could help put some order to it.

@YaelDillies
Copy link
Copy Markdown
Contributor Author

I had a similar thought about generalizing the results to kernels, but I wasn't sure enough to do it without your advice.

I don't know anything about kernels, so i will have to do some reading.

@j-loreaux j-loreaux requested a review from RemyDegenne October 26, 2023 16:30
@RemyDegenne
Copy link
Copy Markdown
Contributor

Sorry, I wrote that I would come back to review more, but the conclusion is simply that this should be generalized and I should have marked it awaiting-author. @YaelDillies, do you mind if I do it and push to this branch?

@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Oct 30, 2023
@YaelDillies
Copy link
Copy Markdown
Contributor Author

Please do! If you don't have time to do it, I can do it myself tonight, since I've now understood what kernels were.

@RemyDegenne RemyDegenne added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Oct 30, 2023
@RemyDegenne
Copy link
Copy Markdown
Contributor

I've generalized everything to kernel independence. Now we need another reviewer. @JasonKYi perhaps?

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 30, 2023
@kex-y
Copy link
Copy Markdown
Member

kex-y commented Oct 30, 2023

Can you resolve the merge conflict?

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 30, 2023
@kex-y
Copy link
Copy Markdown
Member

kex-y commented Oct 31, 2023

Looks good!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by JasonKYi.

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 31, 2023
bors bot pushed a commit that referenced this pull request Oct 31, 2023
Port a bit of leanprover-community/mathlib3#18506, but it's mostly handmade.




Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Oct 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Independence of singletons [Merged by Bors] - feat: Independence of singletons Oct 31, 2023
@bors bors bot closed this Oct 31, 2023
@bors bors bot deleted the independence_singleton branch October 31, 2023 11:52
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
Port a bit of leanprover-community/mathlib3#18506, but it's mostly handmade.




Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants