[Merged by Bors] - chore: delay import of Tactic.Common#7000
Closed
[Merged by Bors] - chore: delay import of Tactic.Common#7000
Conversation
2 tasks
bors bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
I know that this is contrary to what we've done previously, but: * I'm trying to upstream a great many tactics from Mathlib to Std (essentially, everything that non-mathematicians want too). * This makes it much easier for me to see what is going on, and understand the import requirements (particularly for the "big" tactics `norm_num` / `ring` / `linarith`) * It's actually not as bad as it looks here, because as these tactics move up to Std they will start disappearing again from explicit imports, but Mathlib can happily import all of Std. (Oh Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
|
Canceled. |
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
I know that this is contrary to what we've done previously, but: * I'm trying to upstream a great many tactics from Mathlib to Std (essentially, everything that non-mathematicians want too). * This makes it much easier for me to see what is going on, and understand the import requirements (particularly for the "big" tactics `norm_num` / `ring` / `linarith`) * It's actually not as bad as it looks here, because as these tactics move up to Std they will start disappearing again from explicit imports, but Mathlib can happily import all of Std. (Oh Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
I know that this is contrary to what we've done previously, but: * I'm trying to upstream a great many tactics from Mathlib to Std (essentially, everything that non-mathematicians want too). * This makes it much easier for me to see what is going on, and understand the import requirements (particularly for the "big" tactics `norm_num` / `ring` / `linarith`) * It's actually not as bad as it looks here, because as these tactics move up to Std they will start disappearing again from explicit imports, but Mathlib can happily import all of Std. (Oh Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that this is contrary to what we've done previously, but:
norm_num/ring/linarith)(Oh --- and I'll promise when I'm done to clean everything up again. :-)