Conversation
Member
|
Maybe we can add an |
bors bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
This continues reducing the import requirements for the basic algebraic hierarchy. In combination with #6954 #6955 #6956 #6957, this reduces the imports for `Mathlib.Algebra.Field.Defs` from * [before.pdf](https://github.com/leanprover-community/mathlib4/files/12518547/before.pdf) * [after.pdf](https://github.com/leanprover-community/mathlib4/files/12518546/after.pdf) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
Author
|
Good idea: done! |
2 tasks
Member
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
In the basic algebraic hierarchy, the `Defs` files should ideally only depend on earlier `Defs` files, importing as little theory as possible. This PR makes some rearrangements so `Ring.Defs` can depend on `Group.Defs` rather than requiring `Group.Basic`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
ebab
pushed a commit
that referenced
this pull request
Sep 6, 2023
This continues reducing the import requirements for the basic algebraic hierarchy. In combination with #6954 #6955 #6956 #6957, this reduces the imports for `Mathlib.Algebra.Field.Defs` from * [before.pdf](https://github.com/leanprover-community/mathlib4/files/12518547/before.pdf) * [after.pdf](https://github.com/leanprover-community/mathlib4/files/12518546/after.pdf) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
ebab
pushed a commit
that referenced
this pull request
Sep 11, 2023
In the basic algebraic hierarchy, the `Defs` files should ideally only depend on earlier `Defs` files, importing as little theory as possible. This PR makes some rearrangements so `Ring.Defs` can depend on `Group.Defs` rather than requiring `Group.Basic`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
This continues reducing the import requirements for the basic algebraic hierarchy. In combination with #6954 #6955 #6956 #6957, this reduces the imports for `Mathlib.Algebra.Field.Defs` from * [before.pdf](https://github.com/leanprover-community/mathlib4/files/12518547/before.pdf) * [after.pdf](https://github.com/leanprover-community/mathlib4/files/12518546/after.pdf) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
In the basic algebraic hierarchy, the `Defs` files should ideally only depend on earlier `Defs` files, importing as little theory as possible. This PR makes some rearrangements so `Ring.Defs` can depend on `Group.Defs` rather than requiring `Group.Basic`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the basic algebraic hierarchy, the
Defsfiles should ideally only depend on earlierDefsfiles, importing as little theory as possible.This PR makes some rearrangements so
Ring.Defscan depend onGroup.Defsrather than requiringGroup.Basic.