bump: lean4: account for leanprover/lean4#2502#6928
Closed
bump: lean4: account for leanprover/lean4#2502#6928
Conversation
* changes argument type from `List Name` to `Array Name`
* reason: `refine'` was capturing a `_` from a different field's value
* reason: the same: "goal tunneling"
* reason: goal tunneling
* reason: goal tunneling
* reason: goal tunneling; extraneous `swap`
r` * reason: synthetic goal tunneling
* reason: probably goal tunneling; newly-unneeded `exact`.
* reason: synthetic goal tunneling—note that this touched a porting note
1 task
kmill
reviewed
Sep 2, 2023
* fix isolated `←` in `rw` * delete note
sgouezel
reviewed
Sep 3, 2023
|
This PR/issue depends on: |
kim-em
approved these changes
Sep 21, 2023
Contributor
kim-em
left a comment
There was a problem hiding this comment.
I've merged this into the nightly-testing branch. I will roll this in the bump PR for v4.2.0-rc1.
Contributor
|
Subsumed into #7370. |
1 task
bors bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
This rolls in the changed from #6928. Co-authored-by: Thomas Murrills <thomasmurrills@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leanprover/lean4#2502 changes the way
refineandelabTermWithHolesbehaves. In particular, it ensures that both only return new goals:refine eshould only return goals created during elaboration ofe, not pre-existing goals which happen to occur ine.All fixes to
refineandconvert(which uses the underlying infrastructure ofrefine) made by this PR were instances of "goal tunneling", whereinrefine eadded a goal to the list which was not obviously present ine, and had been created earlier—sometimes far earlier, and in one case, in a different field of the structure. Some fixes were minor, needing only the removal of aswap, but some required moving tactic blocks to earlier positions in the proof where they could solve the goal nearer its point of creation. Two touched porting notes.None required any significant alteration of a proof—moving tactic blocks around and sometimes adding a
caseorrefineto expose the goal for solving was the most that was required.refine,elabTermWithHoles, andwithCollectingNewGoalsFromleanprover/lean4#2502