[Merged by Bors] - feat: remove the diamond for Complex.measureSpace#6832
Closed
[Merged by Bors] - feat: remove the diamond for Complex.measureSpace#6832
Conversation
4 tasks
3 tasks
eric-wieser
reviewed
Sep 2, 2023
eric-wieser
approved these changes
Sep 2, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
LGTM
My only question is whether this is considered a "heavy" import, and if it should go in a new Haar.Complex file instead. I'll let another maintainer decide
maintainer merge.
|
🚀 Pull request has been placed on the maintainer queue by eric-wieser. |
Contributor
|
There is a problem with this file, that we have a diamond: complex numbers already have a measure space instance before the start of the file (you can try |
Member
Indeed, this is discussed here |
Collaborator
Author
|
I see, so the plan is to remove the instance at the start of the file (then the Haar measure instance is synthesised automatically) and just come up with a new proof of |
eric-wieser
reviewed
Sep 5, 2023
eric-wieser
reviewed
Sep 5, 2023
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
We prove some lemmas that will be useful in following PRs #6832 and #7037, mainly: ```lean theorem Basis.addHaar_eq {b : Basis ι ℝ E} {b' : Basis ι' ℝ E} : b.addHaar = b'.addHaar ↔ b.addHaar b'.parallelepiped = 1 theorem Basis.parallelepiped_eq_map (b : Basis ι ℝ E) : b.parallelepiped = (TopologicalSpace.PositiveCompacts.piIcc01 ι).map b.equivFun.symm b.equivFunL.symm.continuous theorem Basis.addHaar_map (b : Basis ι ℝ E) (f : E ≃L[ℝ] F) : map f b.addHaar = (b.map f.toLinearEquiv).addHaar ``` Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
We prove some lemmas that will be useful in following PRs #6832 and #7037, mainly: ```lean theorem Basis.addHaar_eq {b : Basis ι ℝ E} {b' : Basis ι' ℝ E} : b.addHaar = b'.addHaar ↔ b.addHaar b'.parallelepiped = 1 theorem Basis.parallelepiped_eq_map (b : Basis ι ℝ E) : b.parallelepiped = (TopologicalSpace.PositiveCompacts.piIcc01 ι).map b.equivFun.symm b.equivFunL.symm.continuous theorem Basis.addHaar_map (b : Basis ι ℝ E) (f : E ≃L[ℝ] F) : map f b.addHaar = (b.map f.toLinearEquiv).addHaar ``` Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
This PR/issue depends on:
|
Member
|
Thanks! 🎉 |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2023
We remove the instance ```lean instance measureSpace : MeasureSpace ℂ := ⟨Measure.map basisOneI.equivFun.symm volume⟩ ``` in `MeasureTheory.Measure.Lebesgue.Complex` since `ℂ` has already a `measureSpace` instance coming from its `InnerProductSpace` structure over `ℝ`, and fix the proof of `volume_preserving_equiv_pi`. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
We prove some lemmas that will be useful in following PRs #6832 and #7037, mainly: ```lean theorem Basis.addHaar_eq {b : Basis ι ℝ E} {b' : Basis ι' ℝ E} : b.addHaar = b'.addHaar ↔ b.addHaar b'.parallelepiped = 1 theorem Basis.parallelepiped_eq_map (b : Basis ι ℝ E) : b.parallelepiped = (TopologicalSpace.PositiveCompacts.piIcc01 ι).map b.equivFun.symm b.equivFunL.symm.continuous theorem Basis.addHaar_map (b : Basis ι ℝ E) (f : E ≃L[ℝ] F) : map f b.addHaar = (b.map f.toLinearEquiv).addHaar ``` Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
We remove the instance ```lean instance measureSpace : MeasureSpace ℂ := ⟨Measure.map basisOneI.equivFun.symm volume⟩ ``` in `MeasureTheory.Measure.Lebesgue.Complex` since `ℂ` has already a `measureSpace` instance coming from its `InnerProductSpace` structure over `ℝ`, and fix the proof of `volume_preserving_equiv_pi`. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We remove the instance
in
MeasureTheory.Measure.Lebesgue.Complexsinceℂhas already ameasureSpaceinstance coming from itsInnerProductSpacestructure overℝ, and fix the proof ofvolume_preserving_equiv_pi.Co-authored-by: Eric Wieser wieser.eric@gmail.com