[Merged by Bors] - fix(Algebra/Module/LinearMap): weaken an over-eager coercion#6786
Closed
eric-wieser wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - fix(Algebra/Module/LinearMap): weaken an over-eager coercion#6786eric-wieser wants to merge 5 commits intomasterfrom
eric-wieser wants to merge 5 commits intomasterfrom
Conversation
We do not want `AlgHom` to cast to `LinearMap` via the rarely-used `DistribMulActionHom`.
8 tasks
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
We do not want `AlgHom` to cast to `LinearMap` via the rarely-used `DistribMulActionHom`. The only places this was used are: * ones that I wrote accidentally, which are replaced with `AlgHom.toLinearMap` (for which lemmas already exist) * a non-unital case, where I've inserted the transitive coercion manually (and a TODO); a syntactic change that does not change the underlying term We could consider adding a `LinearMapClass.toLinearMap` coercion in a future PR, but I would guess this is just unification hell compared to `AlgHom.toLinearMap`, so I don't want to volunteer to do it.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
We do not want `AlgHom` to cast to `LinearMap` via the rarely-used `DistribMulActionHom`. The only places this was used are: * ones that I wrote accidentally, which are replaced with `AlgHom.toLinearMap` (for which lemmas already exist) * a non-unital case, where I've inserted the transitive coercion manually (and a TODO); a syntactic change that does not change the underlying term We could consider adding a `LinearMapClass.toLinearMap` coercion in a future PR, but I would guess this is just unification hell compared to `AlgHom.toLinearMap`, so I don't want to volunteer to do it.
|
Build failed: |
Member
Author
|
bors merge The above was a network failure |
bors bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
We do not want `AlgHom` to cast to `LinearMap` via the rarely-used `DistribMulActionHom`. The only places this was used are: * ones that I wrote accidentally, which are replaced with `AlgHom.toLinearMap` (for which lemmas already exist) * a non-unital case, where I've inserted the transitive coercion manually (and a TODO); a syntactic change that does not change the underlying term We could consider adding a `LinearMapClass.toLinearMap` coercion in a future PR, but I would guess this is just unification hell compared to `AlgHom.toLinearMap`, so I don't want to volunteer to do it.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
We do not want `AlgHom` to cast to `LinearMap` via the rarely-used `DistribMulActionHom`. The only places this was used are: * ones that I wrote accidentally, which are replaced with `AlgHom.toLinearMap` (for which lemmas already exist) * a non-unital case, where I've inserted the transitive coercion manually (and a TODO); a syntactic change that does not change the underlying term We could consider adding a `LinearMapClass.toLinearMap` coercion in a future PR, but I would guess this is just unification hell compared to `AlgHom.toLinearMap`, so I don't want to volunteer to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not want
AlgHomto cast toLinearMapvia the rarely-usedDistribMulActionHom.The only places this was used are:
AlgHom.toLinearMap(for which lemmas already exist)We could consider adding a
LinearMapClass.toLinearMapcoercion in a future PR, but I would guess this is just unification hell compared toAlgHom.toLinearMap, so I don't want to volunteer to do it.