[Merged by Bors] - chore: remove unused simps#6632
Closed
eric-wieser wants to merge 2 commits intomasterfrom
Closed
[Merged by Bors] - chore: remove unused simps#6632eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser wants to merge 2 commits intomasterfrom
Conversation
Member
eric-wieser
commented
Aug 17, 2023
joneugster
reviewed
Aug 17, 2023
f678da9 to
368c049
Compare
Contributor
|
lgtm. Now it seems that there are really only trivial changes left, all of which remove unused (plus one heartbeat raise which isn't really concerning given that there is already a synth-heartbeat raise on the same statement) |
Contributor
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
commented
Aug 17, 2023
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed: |
Member
Author
|
bors merge p=10 |
bors bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
8 tasks
bors bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
The major change here is adapting to `simp` failing if it makes no progress. The vast majority of the redundant `simp`s found due to this change were extracted to #6632. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.