[Merged by Bors] - feat: add Fin.cons_mem_piFinset_iff#6605
Closed
BoltonBailey wants to merge 25 commits intomasterfrom
Closed
[Merged by Bors] - feat: add Fin.cons_mem_piFinset_iff#6605BoltonBailey wants to merge 25 commits intomasterfrom
BoltonBailey wants to merge 25 commits intomasterfrom
Conversation
14 tasks
eric-wieser
reviewed
Aug 16, 2023
eric-wieser
reviewed
Aug 16, 2023
eric-wieser
reviewed
Aug 16, 2023
eric-wieser
reviewed
Aug 16, 2023
Member
|
looks like you committed things that are in lake-packages as submodules somehow please remove them |
alexjbest
reviewed
Sep 7, 2023
alexjbest
reviewed
Sep 7, 2023
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
Co-authored-by: Oliver Nash <github@olivernash.org>
Collaborator
Author
|
For the show_term golfing, I am confused if you want me to do that for the blocks with rcases. Doing that seems to make the proof longer. |
eric-wieser
reviewed
Oct 23, 2023
eric-wieser
reviewed
Oct 23, 2023
eric-wieser
reviewed
Oct 23, 2023
eric-wieser
approved these changes
Oct 23, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
I pushed changes that address all my suggestions; if they look ok to you, please merge; otherwise revert the ones you don't like and ping me.
|
✌️ BoltonBailey can now approve this pull request. To approve and merge a pull request, simply reply with |
…lib4 into BoltonBailey/cons-piFinset
…rover-community/mathlib4 into BoltonBailey/cons-piFinset
Collaborator
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
Adds a lemma about when `Fin.cons` is an element of `piFinset` Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
4 tasks
YaelDillies
added a commit
that referenced
this pull request
Jan 1, 2024
A bunch of lemmas in `Algebra.BigOperators.Ring` were not about rings. This PR moves them along some lemmas from `Data.Fintype.BigOperators` to their correct place. I create a new file with the content from #6605 to avoid importing `Fin` material in finset files as a result. From LeanAPAP
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
A bunch of lemmas in `Algebra.BigOperators.Ring` were not about rings. This PR moves them along with some lemmas from `Data.Fintype.BigOperators` to their correct place. I create a new file with the content from #6605 to avoid importing `Fin` material in finset files as a result. From LeanAPAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lemma about when
Fin.consis an element ofpiFinset