Closed
Conversation
Contributor
JamesGallicchio
commented
Aug 14, 2023
fgdorais
reviewed
Aug 14, 2023
Collaborator
There was a problem hiding this comment.
Using @ makes things hard to maintain. So I think the appropriate fix here is to write a better proof rather than updating the _ pattern.
PS: Oops! I thought this would be a located comment! I'm referring to the error at "Mathlib/Data/List/Nodup.lean:181:44"
0d65227 to
c4f94a9
Compare
c4f94a9 to
18483e7
Compare
18483e7 to
514af3c
Compare
Contributor
|
Rolled into #6721. |
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
This incorporates changes from #6575 I have also renamed `Multiset.countp` to `Multiset.countP` for consistency. Co-authored-by: James Gallichio <jamesgallicchio@gmail.com> Co-authored-by: James <jamesgallicchio@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.