Skip to content

[Merged by Bors] - chore: banish Type _ and Sort _#6499

Closed
mattrobball wants to merge 2 commits intomasterfrom
mrb/banish_type_underscore
Closed

[Merged by Bors] - chore: banish Type _ and Sort _#6499
mattrobball wants to merge 2 commits intomasterfrom
mrb/banish_type_underscore

Conversation

@mattrobball
Copy link
Copy Markdown
Contributor

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.


Open in Gitpod

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Aug 10, 2023
@bors
Copy link
Copy Markdown

bors bot commented Aug 10, 2023

✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mattrobball
Copy link
Copy Markdown
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 10, 2023
We remove all possible occurences of `Type _` and `Sort _` in favor of `Type*` and `Sort*`.

This has nice performance benefits.
@bors
Copy link
Copy Markdown

bors bot commented Aug 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: banish Type _ and Sort _ [Merged by Bors] - chore: banish Type _ and Sort _ Aug 10, 2023
@bors bors bot closed this Aug 10, 2023
@bors bors bot deleted the mrb/banish_type_underscore branch August 10, 2023 21:26
kim-em pushed a commit that referenced this pull request Aug 14, 2023
We remove all possible occurences of `Type _` and `Sort _` in favor of `Type*` and `Sort*`.

This has nice performance benefits.
ocfnash added a commit that referenced this pull request Aug 14, 2023
Necessary because of:
#6528
#6499
kim-em pushed a commit that referenced this pull request Aug 15, 2023
We remove all possible occurences of `Type _` and `Sort _` in favor of `Type*` and `Sort*`.

This has nice performance benefits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants