[Merged by Bors] - perf: change to CommGroup instance on units#6398
Closed
[Merged by Bors] - perf: change to CommGroup instance on units#6398
Conversation
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit e7b2be1. Benchmark Metric Change
========================================================================
- build native linking 5.7%
+ ~Mathlib.CategoryTheory.Monad.Basic instructions -8.3%
+ ~Mathlib.NumberTheory.NumberField.Units instructions -19.5%
+ ~Mathlib.RingTheory.ClassGroup instructions -5.9%
+ ~Mathlib.RingTheory.DedekindDomain.SelmerGroup instructions -42.0% |
Member
Author
|
(NB I think those heartbeats in the class group file could already be removed on master) |
1 task
Contributor
My machine agrees, the number of used heartbeats is 56435 for |
bors bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Fixes a slowdown issue [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Quotient.20slowdowns/near/382006676). The first declaration in that example (the `Basis` example) takes 268578 to elaborate on master but only 11541 (an order of magnitude better) on this branch, and heartbeats no longer need to be bumped.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
Fixes a slowdown issue [reported on Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Quotient.20slowdowns/near/382006676). The first declaration in that example (the `Basis` example) takes 268578 to elaborate on master but only 11541 (an order of magnitude better) on this branch, and heartbeats no longer need to be bumped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a slowdown issue reported on Zulip. The first declaration in that example (the
Basisexample) takes 268578 to elaborate on master but only 11541 (an order of magnitude better) on this branch, and heartbeats no longer need to be bumped.