Skip to content

[Merged by Bors] - chore(Data/Polynomial/FieldDivision): use by_cases instead of if#6314

Closed
eric-wieser wants to merge 2 commits intomasterfrom
classical-tidy
Closed

[Merged by Bors] - chore(Data/Polynomial/FieldDivision): use by_cases instead of if#6314
eric-wieser wants to merge 2 commits intomasterfrom
classical-tidy

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

This is easier to remove from the classical locale in future, and is arguably more readable


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Aug 2, 2023
This is easier to remove from the `classical` locale in future, and is arguably more readable
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Aug 2, 2023

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Aug 2, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Aug 2, 2023
@eric-wieser eric-wieser added the t-algebra Algebra (groups, rings, fields, etc) label Aug 2, 2023
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@bors
Copy link
Copy Markdown

bors bot commented Aug 2, 2023

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 2, 2023
@eric-wieser eric-wieser removed ready-to-merge This PR has been sent to bors. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Aug 2, 2023
@eric-wieser
Copy link
Copy Markdown
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 2, 2023
bors bot pushed a commit that referenced this pull request Aug 2, 2023
…6314)

This is easier to remove from the `classical` locale in future, and is arguably more readable
@bors
Copy link
Copy Markdown

bors bot commented Aug 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Data/Polynomial/FieldDivision): use by_cases instead of if [Merged by Bors] - chore(Data/Polynomial/FieldDivision): use by_cases instead of if Aug 2, 2023
@bors bors bot closed this Aug 2, 2023
@bors bors bot deleted the classical-tidy branch August 2, 2023 19:29
kim-em pushed a commit that referenced this pull request Aug 3, 2023
…6314)

This is easier to remove from the `classical` locale in future, and is arguably more readable
kim-em pushed a commit that referenced this pull request Aug 3, 2023
…6314)

This is easier to remove from the `classical` locale in future, and is arguably more readable
kim-em pushed a commit that referenced this pull request Aug 14, 2023
…6314)

This is easier to remove from the `classical` locale in future, and is arguably more readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants