Skip to content

[Merged by Bors] - chore: golf using compute_degree#6222

Closed
adomani wants to merge 37 commits intomasterfrom
adomani_cd_golf
Closed

[Merged by Bors] - chore: golf using compute_degree#6222
adomani wants to merge 37 commits intomasterfrom
adomani_cd_golf

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Jul 28, 2023

This PR is a companion to #6221. It uses the tactic compute_degree to golf two proofs and restore a proof closer to its mathlib3 version.


Open in Gitpod

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 6, 2023

(Just a reminder that on the mathlib4 repo, if authors don't self-label with awaiting-review, PRs don't appear on the #queue and might never be noticed. :-)

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Aug 6, 2023

Scott, thanks for the heads up! I'll add the dependency on the PR with the tactic and also add the awaiting-review label, then!

@ghost ghost added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Aug 6, 2023
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 2, 2023
@ghost
Copy link
Copy Markdown

ghost commented Sep 2, 2023

This PR/issue depends on:

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 2, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Sep 6, 2023
bors bot pushed a commit that referenced this pull request Sep 6, 2023
This PR is a companion to #6221.  It uses the tactic `compute_degree` to golf two proofs and restore a proof closer to its mathlib3 version.
@bors
Copy link
Copy Markdown

bors bot commented Sep 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: golf using compute_degree [Merged by Bors] - chore: golf using compute_degree Sep 6, 2023
@bors bors bot closed this Sep 6, 2023
@bors bors bot deleted the adomani_cd_golf branch September 6, 2023 10:13
ebab pushed a commit that referenced this pull request Sep 11, 2023
This PR is a companion to #6221.  It uses the tactic `compute_degree` to golf two proofs and restore a proof closer to its mathlib3 version.
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
This PR is a companion to #6221.  It uses the tactic `compute_degree` to golf two proofs and restore a proof closer to its mathlib3 version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants