Skip to content

[Merged by Bors] - refactor of NumberTheory.NumberField.Embeddings#6164

Closed
xroblot wants to merge 3 commits intomasterfrom
xfr-refactor_embeddings
Closed

[Merged by Bors] - refactor of NumberTheory.NumberField.Embeddings#6164
xroblot wants to merge 3 commits intomasterfrom
xfr-refactor_embeddings

Conversation

@xroblot
Copy link
Copy Markdown
Collaborator

@xroblot xroblot commented Jul 26, 2023

Remove unnecessary or redundant results and golf some proofs.


Open in Gitpod

@xroblot xroblot added WIP Work in progress t-number-theory Number theory (also use t-algebra or t-analysis to specialize) awaiting-review and removed WIP Work in progress labels Jul 26, 2023
@riccardobrasca
Copy link
Copy Markdown
Member

I am maybe confused (the diff is a little hard to follow), but why removing place_conjugate (just to give an example)? Is it a special case of something more general?

@xroblot xroblot added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Aug 2, 2023
@xroblot
Copy link
Copy Markdown
Collaborator Author

xroblot commented Aug 3, 2023

I am maybe confused (the diff is a little hard to follow), but why removing place_conjugate (just to give an example)? Is it a special case of something more general?

Since this file became a big mess, especially everything concerning real embeddings, I decided to keep only what was needed for the proof of Dirichlet's theorem. It is possible that I went a bit too far. I'll see if I should put back some results that I deleted and I'll write a better PR description.

@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Aug 3, 2023
bors bot pushed a commit that referenced this pull request Aug 3, 2023
Remove unnecessary or redundant results and golf some proofs.
@bors
Copy link
Copy Markdown

bors bot commented Aug 3, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor of NumberTheory.NumberField.Embeddings [Merged by Bors] - refactor of NumberTheory.NumberField.Embeddings Aug 3, 2023
@bors bors bot closed this Aug 3, 2023
@bors bors bot deleted the xfr-refactor_embeddings branch August 3, 2023 10:45
kim-em pushed a commit that referenced this pull request Aug 3, 2023
Remove unnecessary or redundant results and golf some proofs.
kim-em pushed a commit that referenced this pull request Aug 14, 2023
Remove unnecessary or redundant results and golf some proofs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants