[Merged by Bors] - feat(ImportGraph): add option to exclude imports from other packages#6151
Closed
joneugster wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - feat(ImportGraph): add option to exclude imports from other packages#6151joneugster wants to merge 4 commits intomasterfrom
joneugster wants to merge 4 commits intomasterfrom
Conversation
1 task
kim-em
reviewed
Jul 26, 2023
kim-em
reviewed
Jul 26, 2023
Contributor
|
Could I suggest we make this useful behaviour the default, and instead have a flag |
kim-em
reviewed
Aug 6, 2023
Contributor
|
bors d+ |
|
✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Scott Morrison <scott@tqft.net>
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2023
…6151) Add an option `lake exe graph --to MyProject.XY --noDep` which removes all nodes that do not start in `MyProject`.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
pushed a commit
that referenced
this pull request
Aug 14, 2023
…6151) Add an option `lake exe graph --to MyProject.XY --noDep` which removes all nodes that do not start in `MyProject`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option
lake exe graph --to MyProject.XY --noDepwhich removes all nodes that do not start inMyProject.Note that currently omitting
--tois equivalent to specifying--to Mathlib, so there is no special case needed to handle this.Happy to get a suggestion for a better name, maybe
--exclude-dependencies?