Skip to content

[Merged by Bors] - feat(Algebra/IndicatorFunction): add indicator_iInter_apply as a counterpart to indicator_iUnion_apply.#6078

Closed
kkytola wants to merge 1 commit intomasterfrom
kkytola/indicator_iInter_apply
Closed

[Merged by Bors] - feat(Algebra/IndicatorFunction): add indicator_iInter_apply as a counterpart to indicator_iUnion_apply.#6078
kkytola wants to merge 1 commit intomasterfrom
kkytola/indicator_iInter_apply

Conversation

@kkytola
Copy link
Copy Markdown
Collaborator

@kkytola kkytola commented Jul 23, 2023

Add lemma mulIndicator_iInter_apply and its additive version indicator_iInter_apply. These are entirely parallel to the existing mulIndicator_iUnion_apply and its additive version indicator_iUnion_apply.


Open in Gitpod

@eric-wieser eric-wieser added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 23, 2023
@eric-wieser
Copy link
Copy Markdown
Member

bors d+

LGTM, thanks! Do you think it's worth having the _apply-free version too, mulIndicator (⋂ i, s i) f = ⨅ i, mulIndicator (s i) f?

@bors
Copy link
Copy Markdown

bors bot commented Jul 23, 2023

✌️ kkytola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 23, 2023
@kkytola
Copy link
Copy Markdown
Collaborator Author

kkytola commented Jul 24, 2023

bors d+

LGTM, thanks! Do you think it's worth having the _apply-free version too, mulIndicator (⋂ i, s i) f = ⨅ i, mulIndicator (s i) f?

Thank you!

That is a good question! I don't have enough experience to have a clear opinion on that. (I guess that has to do with how canonical the sup/inf spelling of functions is considered.)

Based on just (1) the fact that the existing mulIndicator_iUnion_apply did not have this _apply-free version and (2) that when I noticed the missing lemma, I wanted the _apply-ful/pointwise version, I would default to not adding those _apply-free versions for now.

@kkytola
Copy link
Copy Markdown
Collaborator Author

kkytola commented Jul 24, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jul 24, 2023
…terpart to indicator_iUnion_apply. (#6078)

Add lemma `mulIndicator_iInter_apply` and its additive version `indicator_iInter_apply`. These are entirely parallel to the existing `mulIndicator_iUnion_apply` and its additive version `indicator_iUnion_apply`.
@bors
Copy link
Copy Markdown

bors bot commented Jul 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Algebra/IndicatorFunction): add indicator_iInter_apply as a counterpart to indicator_iUnion_apply. [Merged by Bors] - feat(Algebra/IndicatorFunction): add indicator_iInter_apply as a counterpart to indicator_iUnion_apply. Jul 24, 2023
@bors bors bot closed this Jul 24, 2023
@bors bors bot deleted the kkytola/indicator_iInter_apply branch July 24, 2023 15:23
fgdorais pushed a commit that referenced this pull request Jul 25, 2023
…terpart to indicator_iUnion_apply. (#6078)

Add lemma `mulIndicator_iInter_apply` and its additive version `indicator_iInter_apply`. These are entirely parallel to the existing `mulIndicator_iUnion_apply` and its additive version `indicator_iUnion_apply`.
kim-em pushed a commit that referenced this pull request Aug 14, 2023
…terpart to indicator_iUnion_apply. (#6078)

Add lemma `mulIndicator_iInter_apply` and its additive version `indicator_iInter_apply`. These are entirely parallel to the existing `mulIndicator_iUnion_apply` and its additive version `indicator_iUnion_apply`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants