[Merged by Bors] - feat: nontriviality tactic#600
Closed
Conversation
df4c240 to
2a37346
Compare
Contributor
|
CI failures are caused by the issue reported and fixed at leanprover/lean4#1829. We'll need to bump, but bumping to 2022-11-16 is blocked by leanprover/lean4#1842. |
1 task
Contributor
|
Merging master fixes the build; just some missing documentation now |
Contributor
|
bors merge |
|
Merge conflict. |
1a26ea3 to
7727c1c
Compare
Member
Author
|
bors merge |
Member
Author
|
bors ping |
|
pong |
Member
Author
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded:
|
nontriviality tacticnontriviality tactic
dwrensha
reviewed
Nov 21, 2022
| * (not implemented yet) `solve_by_elim with attr₁ ... attrᵣ` also applies all lemmas tagged with | ||
| the specified attributes. | ||
| * `solve_by_elim [h₁, h₂, ..., hᵣ, attr₁, ... attrᵣ]` also applies the named lemmas, as well as | ||
| all lemmas tagged with the specified attributes. |
Member
There was a problem hiding this comment.
@digama0 has support been added to solve_by_elim so that it now with with attributes like this? If not, this comment should be marked "not implemented yet".
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
mathlib hash: 7cca171008afb30576d2d4c51173700a780c23d0 - [x] depends on: #600 Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yakov Pechersky <ffxen158@gmail.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #548.