[Merged by Bors] - chore: bump to nightly-2023-07-15#5992
Closed
[Merged by Bors] - chore: bump to nightly-2023-07-15#5992
Conversation
Contributor
Author
|
This will need a fix to Std4. Edit: DONE. |
Contributor
Author
|
This is currently failing in |
Contributor
|
Now it is failing on the |
8 tasks
|
This PR/issue depends on:
|
urkud
reviewed
Jul 23, 2023
Member
|
Thanks! 🎉 |
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
Various adaptations to changes when `Fin` API was moved to Std. One notable change is that many lemmas are now stated in terms of `i ≠ 0` (for `i : Fin n`) rather then `i.1 ≠ 0`, and as a consequence many `Fin.vne_of_ne` applications have been added or removed, mostly removed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com>
eric-wieser
reviewed
Jul 27, 2023
eric-wieser
reviewed
Jul 27, 2023
eric-wieser
reviewed
Jul 27, 2023
eric-wieser
reviewed
Jul 27, 2023
|
Canceled. |
eric-wieser
reviewed
Jul 27, 2023
Mathlib/Data/Fin/Basic.lean
Outdated
Comment on lines
+1331
to
+1342
| /-- `succAbove p i` embeds `Fin n` into `Fin (n + 1)` with a hole around `p`. -/ | ||
| def succAbove (p : Fin (n + 1)) (i : Fin n) : Fin (n + 1) := | ||
| if i.1 < p.1 then castSucc i else succ i | ||
|
|
||
| /-- `predAbove p i` embeds `i : Fin (n+1)` into `Fin n` by subtracting one if `p < i`. -/ | ||
| def predAbove (p : Fin n) (i : Fin (n + 1)) : Fin n := | ||
| if h : castSucc p < i then i.pred ((ne_iff_vne i 0).mpr (Nat.not_eq_zero_of_lt h)) | ||
| else i.castLT (Nat.lt_of_le_of_lt (Nat.ge_of_not_lt h) p.2) | ||
|
|
||
| /-- `castPred` embeds `i : Fin (n + 2)` into `Fin (n + 1)` | ||
| by lowering just `last (n + 1)` to `last n`. -/ | ||
| def castPred (i : Fin (n + 2)) : Fin (n + 1) := predAbove (last n) i |
Member
There was a problem hiding this comment.
Should we put these back to how they were in mathlib3 (ie, rename succAboveEmb back to succAbove)
Member
There was a problem hiding this comment.
mathlib4/Mathlib/Data/Fin/Basic.lean
Lines 2032 to 2042 in f4e4287
Member
There was a problem hiding this comment.
Ah, only succAbove was changed; I moved the other lemmas back to their original (unbundled) homes.
eric-wieser
reviewed
Jul 27, 2023
2 tasks
Member
|
bors d+ The |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
Various adaptations to changes when `Fin` API was moved to Std. One notable change is that many lemmas are now stated in terms of `i ≠ 0` (for `i : Fin n`) rather then `i.1 ≠ 0`, and as a consequence many `Fin.vne_of_ne` applications have been added or removed, mostly removed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
adomani
pushed a commit
that referenced
this pull request
Jul 28, 2023
Various adaptations to changes when `Fin` API was moved to Std. One notable change is that many lemmas are now stated in terms of `i ≠ 0` (for `i : Fin n`) rather then `i.1 ≠ 0`, and as a consequence many `Fin.vne_of_ne` applications have been added or removed, mostly removed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kim-em
added a commit
that referenced
this pull request
Aug 14, 2023
Various adaptations to changes when `Fin` API was moved to Std. One notable change is that many lemmas are now stated in terms of `i ≠ 0` (for `i : Fin n`) rather then `i.1 ≠ 0`, and as a consequence many `Fin.vne_of_ne` applications have been added or removed, mostly removed. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various adaptations to changes when
FinAPI was moved to Std. One notable change is that many lemmas are now stated in terms ofi ≠ 0(fori : Fin n) rather theni.1 ≠ 0, and as a consequence manyFin.vne_of_neapplications have been added or removed, mostly removed.