[Merged by Bors] - chore: script to replace headers with #align_import statements#5979
Closed
[Merged by Bors] - chore: script to replace headers with #align_import statements#5979
Conversation
|
This PR/issue depends on:
|
eric-wieser
reviewed
Jul 19, 2023
Comment on lines
+1
to
+4
| #!/usr/bin/env python3 | ||
|
|
||
| # This script was written by ChatGPT. | ||
| # https://chat.openai.com/share/e0363ebf-ed6f-4fd8-9b76-ebf422ed9f62 |
Member
There was a problem hiding this comment.
This should include a doc-comment along the lines of:
"""
This script was used in #5979 to convert from one header format to another.
It can be safely deleted in a few weeks.
"""
Member
There was a problem hiding this comment.
Or we could just delete it and not ever commit it; it's only use is being in the history for this PR, really.
eric-wieser
approved these changes
Jul 19, 2023
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Some downstream stuff will break, and I won't be fixing it for at least 8 hours.
Merging in 6 hours or so is probably a good compromise, since it might take some time to propagate anyway.
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
Thanks 🎉 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
- [x] depends on: #5966 [](https://gitpod.io/from-referrer/) Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
kim-em
added a commit
that referenced
this pull request
Aug 14, 2023
- [x] depends on: #5966 [](https://gitpod.io/from-referrer/) Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
align_importcommand #5966