Skip to content

[Merged by Bors] - chore: empty ports of the Data/Buffer/Parser files#5848

Closed
kim-em wants to merge 8 commits intomasterfrom
port/Data.Buffer.Parser.Numeral
Closed

[Merged by Bors] - chore: empty ports of the Data/Buffer/Parser files#5848
kim-em wants to merge 8 commits intomasterfrom
port/Data.Buffer.Parser.Numeral

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jul 13, 2023

Open in Gitpod

kim-em added 4 commits July 13, 2023 16:45
@kim-em
feat: port Data.Buffer.Parser.Numeral
23b699a
@kim-em
Initial file copy from mathport
e615938
@kim-em
automated fixes
3572b33 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@kim-em
empty ports of the Data/Buffer files
92a94d4
@kim-em kim-em added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 13, 2023
jcommelin
jcommelin reviewed Jul 13, 2023
View reviewed changes
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Jul 13, 2023

The three porting headers do not all refer to the same commit hash. Is that on purpose?

kim-em
kim-em commented Jul 13, 2023
View reviewed changes
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jul 13, 2023

The three porting headers do not all refer to the same commit hash. Is that on purpose?

Not sure how that happened. mathlib3 updated underneath me? Anyway, they are all the same now.

@kim-em @jcommelin
Update Mathlib/Data/Buffer/Parser/Numeral.lean
461d2eb 
Co-authored-by: Johan Commelin <johan@commelin.net>
@jcommelin
Copy link
Copy Markdown
Member

jcommelin commented Jul 13, 2023

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Jul 13, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 13, 2023
@fpvandoorn
Copy link
Copy Markdown
Member

fpvandoorn commented Jul 13, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 13, 2023
bors bot pushed a commit that referenced this pull request Jul 13, 2023
@kim-em
chore: empty ports of the Data/Buffer/Parser files (#5848)
b41e763 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jul 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: empty ports of the Data/Buffer/Parser files [Merged by Bors] - chore: empty ports of the Data/Buffer/Parser files Jul 13, 2023
@bors bors bot closed this Jul 13, 2023
@bors bors bot deleted the port/Data.Buffer.Parser.Numeral branch July 13, 2023 08:35
@Komyyy Komyyy mentioned this pull request Jul 13, 2023
Closed
bors bot pushed a commit that referenced this pull request Jul 13, 2023
@Komyyy
chore: empty port of the Data.Buffer.Parser in core (#5864)
4d8f5b5 
addition to #5848
kim-em added a commit that referenced this pull request Aug 14, 2023
@kim-em
chore: empty ports of the Data/Buffer/Parser files (#5848)
9570d7f 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em pushed a commit that referenced this pull request Aug 14, 2023
@Komyyy @kim-em
chore: empty port of the Data.Buffer.Parser in core (#5864)
f5ac30d 
addition to #5848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees

No one assigned

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kim-em @jcommelin @fpvandoorn