[Merged by Bors] - chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std#5847
Closed
[Merged by Bors] - chore: replace Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std#5847
Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std#5847Conversation
Fin.castIso and Fin.revPerm with Fin.cast and Fin.revFin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std
eric-wieser
reviewed
Jul 13, 2023
Closed
Contributor
|
Are these changes improvements? |
Contributor
Author
|
@Ruben-VandeVelde Recently, the definitions like |
Member
|
I think this change is probably a good thing given that Std4 changed in the way it did, as the canonical form should usually be the lowest-common-denominator of all available bundlings. |
kim-em
reviewed
Jul 20, 2023
kim-em
reviewed
Jul 20, 2023
Member
|
@semorrison Could you please take a look at this PR? |
kim-em
reviewed
Sep 12, 2023
jcommelin
reviewed
Sep 12, 2023
Member
jcommelin
left a comment
There was a problem hiding this comment.
One comment (applies in several places). Otherwise LGTM
Thanks for this PR!
bors d+
|
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2023
…in.rev` for the bump of Std (#5847) Some theorems in `Data.Fin.Basic` are copied to Std at the recent commit in Std. These are written using `Fin.cast` and `Fin.rev`, so declarations using `Fin.castIso` and `Fin.revPerm` in Mathlib should be rewritten. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Fin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of StdFin.castIso and Fin.revPerm with Fin.cast and Fin.rev for the bump of Std
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
…in.rev` for the bump of Std (#5847) Some theorems in `Data.Fin.Basic` are copied to Std at the recent commit in Std. These are written using `Fin.cast` and `Fin.rev`, so declarations using `Fin.castIso` and `Fin.revPerm` in Mathlib should be rewritten. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some theorems in
Data.Fin.Basicare copied to Std at the recent commit in Std.These are written using
Fin.castandFin.rev, so declarations usingFin.castIsoandFin.revPermin Mathlib should be rewritten.