[Merged by Bors] - feat: improve ToAdditive.guessName to work with capitalisation#579
Closed
joneugster wants to merge 21 commits intomasterfrom
Closed
[Merged by Bors] - feat: improve ToAdditive.guessName to work with capitalisation#579joneugster wants to merge 21 commits intomasterfrom
ToAdditive.guessName to work with capitalisation#579joneugster wants to merge 21 commits intomasterfrom
Conversation
to_additive to new naming convention.ToAdditive.guessName to guess capitalisation
ToAdditive.guessName to guess capitalisationToAdditive.guessName to work with capitalisation
ToAdditive.guessName to work with capitalisationToAdditive.guessName to work with capitalisation
Member
|
Can you add test cases to the test file? Regarding performance, I can't imagine there is anything you can do here which would have unacceptable performance. It is only run once per declaration and it's a tiny input so it shouldn't be a problem. |
Contributor
Author
|
Done that :) |
1 task
kim-em
reviewed
Nov 17, 2022
kim-em
reviewed
Nov 17, 2022
Contributor
|
I made a few further changes. If you happy, please go ahead and merge. bors d+ |
|
✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Scott Morrison <scott@tqft.net>
Co-authored-by: Scott Morrison <scott@tqft.net>
Contributor
Author
|
Thanks @semorrison ! I made a few more minor changes, all fixes to the test cases. |
Contributor
Author
|
bors r+ |
Contributor
Author
|
bors ping |
|
pong |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
This is a suggestion for `to_additive` to parse names in the new naming conventions. It does keep capitalised abbreviations like "LE" together but it would not split a single capitalised char off. E.g. "OneCommMonoidLEHMul_one_lt_Conj₂Pow" becomes "ZeroAddCommMonoidLEHAdd_pos_Conj₂Nsmul" Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
digama0
reviewed
Nov 17, 2022
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Canceled. |
Contributor
Author
|
I hope it's okay if I merge now with your comments integrated @digama0 . Please cancel if not! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
This is a suggestion for `to_additive` to parse names in the new naming conventions. It does keep capitalised abbreviations like "LE" together but it would not split a single capitalised char off. E.g. "OneCommMonoidLEHMul_one_lt_Conj₂Pow" becomes "ZeroAddCommMonoidLEHAdd_pos_Conj₂Nsmul" Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
ToAdditive.guessName to work with capitalisationToAdditive.guessName to work with capitalisation
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
- [x] depends on: #579 Mathlib SHA: 17a9f8f7a4ef32ee65d418103367cf30e84e631d Done with the reviews. This should hopefully now be ready to merge. Co-authored-by: Jon <jon.eugster@gmx.ch> Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a suggestion for
to_additiveto parse names in the new naming conventions.It does keep capitalised abbreviations like "LE" together but it would not split a single capitalised char off.
E.g. "OneCommMonoidLEHMul_one_lt_Conj₂Pow" becomes "ZeroAddCommMonoidLEHAdd_pos_Conj₂Nsmul"