Skip to content

[Merged by Bors] - chore: remove occurrences of semicolon after space#5713

Closed
Parcly-Taxel wants to merge 3 commits intomasterfrom
fixsemicolons
Closed

[Merged by Bors] - chore: remove occurrences of semicolon after space#5713
Parcly-Taxel wants to merge 3 commits intomasterfrom
fixsemicolons

Conversation

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

@Parcly-Taxel Parcly-Taxel commented Jul 4, 2023

This is the second half of the changes originally in #5699, removing all occurrences of ; after a space and implementing a linter rule to enforce it.

In most cases this 2-character substring has a space after it, so the following command was run first:

find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \;

The remaining cases were few enough in number that they were done manually.


Open in Gitpod

find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \;
@Parcly-Taxel Parcly-Taxel added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jul 4, 2023
@Parcly-Taxel Parcly-Taxel changed the title chore: remove occurrences of ; chore: remove occurrences of semicolon after space Jul 4, 2023
@Parcly-Taxel Parcly-Taxel requested review from jcommelin and kim-em July 4, 2023 14:17
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 4, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link
Copy Markdown

bors bot commented Jul 4, 2023

✌️ Parcly-Taxel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kim-em kim-em added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Jul 4, 2023
@Parcly-Taxel
Copy link
Copy Markdown
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 4, 2023
This is the second half of the changes originally in #5699, removing all occurrences of `;` _after_ a space and implementing a linter rule to enforce it.

In most cases this 2-character substring has a space after it, so the following command was run first:
```
find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \;
```
The remaining cases were few enough in number that they were done manually.
@bors
Copy link
Copy Markdown

bors bot commented Jul 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: remove occurrences of semicolon after space [Merged by Bors] - chore: remove occurrences of semicolon after space Jul 4, 2023
@bors bors bot closed this Jul 4, 2023
@bors bors bot deleted the fixsemicolons branch July 4, 2023 17:42
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
This is the second half of the changes originally in #5699, removing all occurrences of `;` _after_ a space and implementing a linter rule to enforce it.

In most cases this 2-character substring has a space after it, so the following command was run first:
```
find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \;
```
The remaining cases were few enough in number that they were done manually.
kim-em pushed a commit that referenced this pull request Aug 14, 2023
This is the second half of the changes originally in #5699, removing all occurrences of `;` _after_ a space and implementing a linter rule to enforce it.

In most cases this 2-character substring has a space after it, so the following command was run first:
```
find . -type f -name "*.lean" -exec sed -i -E 's/ ; /; /g' {} \;
```
The remaining cases were few enough in number that they were done manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants