Conversation
|
Could you add comments (I'd say both in the module docstrings and in the docs of the definitions) warning that this is not the dual of the |
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
ADedecker
left a comment
There was a problem hiding this comment.
Final set of nitpicks.
Thanks!
bors d+
|
✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
|
bors r+ |
…or Alexandrov) topology and the Lower Set topology (#5672) Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
…or Alexandrov) topology and the Lower Set topology (#5672) Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
…or Alexandrov) topology and the Lower Set topology (#5672) Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
…or Alexandrov) topology and the Lower Set topology (#5672) Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
…or Alexandrov) topology and the Lower Set topology (#5672) Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology. Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com> Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.
An Alexandrov topology is a topology where the intersection of any collection of open sets is open. The
UpperSetTopologyis an Alexandrov topology, and, given any Alexandrov topology, aPreordermay be defined on the underlying set such that theUpperSetTopologyof thePreordercoincides with the original topology.However, our motivation for introducing the
UpperSetTopologyis its use in the construction of the Scott Topology (#2508). Beyond demonstrating that the set of open sets is closed under arbitrary intersections, we have not sought to further develop the theory of Alexandrov topologies in this PR. However, we hope that by breaking the Upper Set topology out into a separate file / PR, we may facilitate anyone who does wish to develop mathlib4 in that direction.See also the discussion about naming here
For completeness we also introduce the dual Lower Set topology.