Skip to content

[Merged by Bors] - feat(Topology/Order/UpperLowerSetTopology): Introduce the Upper Set (or Alexandrov) topology and the Lower Set topology#5672

Closed
mans0954 wants to merge 75 commits intomasterfrom
mans0954/upper-set-topology
Closed

[Merged by Bors] - feat(Topology/Order/UpperLowerSetTopology): Introduce the Upper Set (or Alexandrov) topology and the Lower Set topology#5672
mans0954 wants to merge 75 commits intomasterfrom
mans0954/upper-set-topology

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

@mans0954 mans0954 commented Jul 2, 2023

Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.


An Alexandrov topology is a topology where the intersection of any collection of open sets is open. The UpperSetTopology is an Alexandrov topology, and, given any Alexandrov topology, a Preorder may be defined on the underlying set such that the UpperSetTopology of the Preorder coincides with the original topology.

However, our motivation for introducing the UpperSetTopology is its use in the construction of the Scott Topology (#2508). Beyond demonstrating that the set of open sets is closed under arbitrary intersections, we have not sought to further develop the theory of Alexandrov topologies in this PR. However, we hope that by breaking the Upper Set topology out into a separate file / PR, we may facilitate anyone who does wish to develop mathlib4 in that direction.

See also the discussion about naming here

For completeness we also introduce the dual Lower Set topology.

Open in Gitpod

@ADedecker ADedecker self-assigned this Jul 10, 2023
@ADedecker
Copy link
Copy Markdown
Member

Could you add comments (I'd say both in the module docstrings and in the docs of the definitions) warning that this is not the dual of the LowerTopology? Maybe even add an example in the module docstring.

@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jul 11, 2023
mans0954 and others added 5 commits July 11, 2023 18:00
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@ghost ghost added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Jul 31, 2023
@ghost
Copy link
Copy Markdown

ghost commented Jul 31, 2023

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 1, 2023
Copy link
Copy Markdown
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final set of nitpicks.

Thanks!
bors d+

@bors
Copy link
Copy Markdown

bors bot commented Aug 1, 2023

✌️ mans0954 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Aug 1, 2023
mans0954 and others added 7 commits August 1, 2023 18:18
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@mans0954
Copy link
Copy Markdown
Collaborator Author

mans0954 commented Aug 1, 2023

bors r+

bors bot pushed a commit that referenced this pull request Aug 1, 2023
…or Alexandrov) topology and the Lower Set topology (#5672)

Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
@bors
Copy link
Copy Markdown

bors bot commented Aug 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Topology/Order/UpperLowerSetTopology): Introduce the Upper Set (or Alexandrov) topology and the Lower Set topology [Merged by Bors] - feat(Topology/Order/UpperLowerSetTopology): Introduce the Upper Set (or Alexandrov) topology and the Lower Set topology Aug 1, 2023
@bors bors bot closed this Aug 1, 2023
@bors bors bot deleted the mans0954/upper-set-topology branch August 1, 2023 18:35
kim-em pushed a commit that referenced this pull request Aug 2, 2023
…or Alexandrov) topology and the Lower Set topology (#5672)

Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
kim-em pushed a commit that referenced this pull request Aug 2, 2023
…ff (#6157)

Add if and only if versions of `Monotone.dual` and `Antitone.dual`.

Needed for #5672



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
kim-em pushed a commit that referenced this pull request Aug 2, 2023
…or Alexandrov) topology and the Lower Set topology (#5672)

Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
kim-em pushed a commit that referenced this pull request Aug 3, 2023
…or Alexandrov) topology and the Lower Set topology (#5672)

Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
kim-em pushed a commit that referenced this pull request Aug 14, 2023
…ff (#6157)

Add if and only if versions of `Monotone.dual` and `Antitone.dual`.

Needed for #5672



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@gmail.com>
kim-em pushed a commit that referenced this pull request Aug 14, 2023
…or Alexandrov) topology and the Lower Set topology (#5672)

Introduces the Upper Set topology, which is the canonical example of an Alexandrov topology and its dual, the Lower Set topology.



Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants