Skip to content

[Merged by Bors] - feat(LinearAlgebra.Finsupp): add countable instance#5671

Closed
xroblot wants to merge 1 commit intomasterfrom
xfr-countable_span
Closed

[Merged by Bors] - feat(LinearAlgebra.Finsupp): add countable instance#5671
xroblot wants to merge 1 commit intomasterfrom
xfr-countable_span

Conversation

@xroblot
Copy link
Copy Markdown
Collaborator

@xroblot xroblot commented Jul 2, 2023

Add the instance:

instance {ι : Type _} [Countable R] [Countable ι] (v : ι → M) : Countable (Submodule.span R (Set.range v))

which is needed to be able to apply Minkowski theorem to ℤ-lattices. This instance, in turn, uses the new instance:

instance [Countable α] [Countable M] : Countable (α →₀ M)

Open in Gitpod

@xroblot xroblot changed the title feat (LinearAlgebra.Finsupp): add countable instance feat(LinearAlgebra.Finsupp): add countable instance Jul 5, 2023
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jul 8, 2023

Please remember to add the label awaiting-review when this is ready for review. (Alternatively PRs that refactor files that were ported from mathlib3 should be labelled after-port.)

@xroblot xroblot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 16, 2023
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Jul 21, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jul 21, 2023
bors bot pushed a commit that referenced this pull request Jul 21, 2023
Add the instance: 
```lean
instance {ι : Type _} [Countable R] [Countable ι] (v : ι → M) : Countable (Submodule.span R (Set.range v))
```
which is needed to be able to apply Minkowski theorem to ℤ-lattices. This instance, in turn, uses the new instance:
```lean
instance [Countable α] [Countable M] : Countable (α →₀ M)
```
@bors
Copy link
Copy Markdown

bors bot commented Jul 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(LinearAlgebra.Finsupp): add countable instance [Merged by Bors] - feat(LinearAlgebra.Finsupp): add countable instance Jul 21, 2023
@bors bors bot closed this Jul 21, 2023
@bors bors bot deleted the xfr-countable_span branch July 21, 2023 14:16
fgdorais pushed a commit that referenced this pull request Jul 25, 2023
Add the instance: 
```lean
instance {ι : Type _} [Countable R] [Countable ι] (v : ι → M) : Countable (Submodule.span R (Set.range v))
```
which is needed to be able to apply Minkowski theorem to ℤ-lattices. This instance, in turn, uses the new instance:
```lean
instance [Countable α] [Countable M] : Countable (α →₀ M)
```
kim-em pushed a commit that referenced this pull request Aug 14, 2023
Add the instance: 
```lean
instance {ι : Type _} [Countable R] [Countable ι] (v : ι → M) : Countable (Submodule.span R (Set.range v))
```
which is needed to be able to apply Minkowski theorem to ℤ-lattices. This instance, in turn, uses the new instance:
```lean
instance [Countable α] [Countable M] : Countable (α →₀ M)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants