[Merged by Bors] - feat: quotient lift on a finite family#5576
Closed
astrainfinita wants to merge 24 commits intomasterfrom
Closed
[Merged by Bors] - feat: quotient lift on a finite family#5576astrainfinita wants to merge 24 commits intomasterfrom
astrainfinita wants to merge 24 commits intomasterfrom
Conversation
2 tasks
Collaborator
Author
|
That was leanprover-community/mathlib3#18318 but had been solved in a slightly more complicated way in #13235. See #15156 for golf. In the future it may be used to prove that |
This reverts commit ee8e506.
Contributor
Cn you add that t othe PR description? |
YaelDillies
approved these changes
Nov 2, 2024
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
maintainer merge
apart from that. Thanks!
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
…ty/mathlib4 into FR_quotient2'
eric-wieser
reviewed
Nov 2, 2024
eric-wieser
reviewed
Nov 2, 2024
eric-wieser
reviewed
Nov 2, 2024
Vierkantor
reviewed
Nov 4, 2024
| Authors: Mario Carneiro | ||
| Authors: Mario Carneiro, Yuyang Zhao | ||
| -/ | ||
| import Mathlib.Data.List.Pi |
Contributor
There was a problem hiding this comment.
I'm a bit wary of adding extra imports here since this file does get imported by a big chunk of Mathlib. But looking at the import graph, most of those dependencies look like good splitting candidates anyway, so I think on balance it does not cause a bigger tangle than we already have.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
In the future it may be used to prove that `ZFSet` is a model of ZF set theory without using `Classical.choice`. Specifically, it will be used to prove that all first-order formulas of `ZFSet` are definable. Comparing to `(finChoice q).liftOn f`, `finLiftOn q f` asks users to provide a proof of `(∀ i, a i ≈ b i) → f a = f b` instead of `a ≈ b → f a = f b`, which is more readable and easier to rewrite. It also makes it easier for users to discover and use relevant APIs. Co-authored-by: negiizhao <egresf@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future it may be used to prove that
ZFSetis a model of ZF set theory without usingClassical.choice. Specifically, it will be used to prove that all first-order formulas ofZFSetare definable.Comparing to
(finChoice q).liftOn f,finLiftOn q fasks users to provide a proof of(∀ i, a i ≈ b i) → f a = f binstead ofa ≈ b → f a = f b, which is more readable and easier to rewrite. It also makes it easier for users to discover and use relevant APIs.Data/List/Pi#5549