Skip to content

[Merged by Bors] - feat: abel_nf, abel tactic#555

Closed
digama0 wants to merge 2 commits intomasterfrom
abel_nf
Closed

[Merged by Bors] - feat: abel_nf, abel tactic#555
digama0 wants to merge 2 commits intomasterfrom
abel_nf

Conversation

@digama0
Copy link
Copy Markdown
Member

@digama0 digama0 commented Nov 8, 2022

This is basically a copy-paste job from ring_nf. It adds the analogous things for abel:

  • abel1 solves abelian group equalities
  • abel_nf rewrites abelian group equalities in hyps or target to a normal form, including recursively inside atoms
  • abel_nf is also a conv tactic that does the same thing
  • abel calls abel1 and then abel_nf with a trace message
  • abel is also a conv tactic that solves equalities by rewriting them to True

@digama0
Copy link
Copy Markdown
Member Author

digama0 commented Nov 14, 2022

bors merge

bors bot pushed a commit that referenced this pull request Nov 14, 2022
This is basically a copy-paste job from `ring_nf`. It adds the analogous things for `abel`:

* `abel1` solves abelian group equalities
* `abel_nf` rewrites abelian group equalities in hyps or target to a normal form, including recursively inside atoms
* `abel_nf` is also a conv tactic that does the same thing
* `abel` calls `abel1` and then `abel_nf` with a trace message
* `abel` is also a conv tactic that solves equalities by rewriting them to `True`

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Nov 14, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: abel_nf, abel tactic [Merged by Bors] - feat: abel_nf, abel tactic Nov 14, 2022
@bors bors bot closed this Nov 14, 2022
@bors bors bot deleted the abel_nf branch November 14, 2022 20:43
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants