Skip to content

[Merged by Bors] - chore: clean up spacing around at and goals#5387

Closed
alexjbest wants to merge 3 commits intomasterfrom
alexjbest/at-spacing
Closed

[Merged by Bors] - chore: clean up spacing around at and goals#5387
alexjbest wants to merge 3 commits intomasterfrom
alexjbest/at-spacing

Conversation

@alexjbest
Copy link
Copy Markdown
Member

Changes are of the form

  • some_tactic at h⊢ -> some_tactic at h ⊢
  • some_tactic at h -> some_tactic at h

@digama0 I guess this is a small mathport bug, can it be fixed?

Open in Gitpod

@alexjbest alexjbest added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 22, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 22, 2023
@digama0
Copy link
Copy Markdown
Member

digama0 commented Jun 23, 2023

@digama0 I guess this is a small mathport bug, can it be fixed?

It's already fixed, but mathport fixes don't automatically back-propagate to the 90% of mathlib that has already been ported. See #4519 and the linked issues if you would like to find some other spacing fixes to back-propagate.

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Jun 23, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 23, 2023
bors bot pushed a commit that referenced this pull request Jun 23, 2023
Changes are of the form
- `some_tactic at h⊢` ->  `some_tactic at h ⊢`
- `some_tactic  at h` -> `some_tactic at h`
@bors
Copy link
Copy Markdown

bors bot commented Jun 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: clean up spacing around at and goals [Merged by Bors] - chore: clean up spacing around at and goals Jun 23, 2023
@bors bors bot closed this Jun 23, 2023
@bors bors bot deleted the alexjbest/at-spacing branch June 23, 2023 07:23
kim-em pushed a commit that referenced this pull request Jun 25, 2023
Changes are of the form
- `some_tactic at h⊢` ->  `some_tactic at h ⊢`
- `some_tactic  at h` -> `some_tactic at h`
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Changes are of the form
- `some_tactic at h⊢` ->  `some_tactic at h ⊢`
- `some_tactic  at h` -> `some_tactic at h`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants