Skip to content

[Merged by Bors] - chore: fix backtick in docs#5077

Closed
int-y1 wants to merge 1 commit intomasterfrom
fix-backtick
Closed

[Merged by Bors] - chore: fix backtick in docs#5077
int-y1 wants to merge 1 commit intomasterfrom
fix-backtick

Conversation

@int-y1
Copy link
Copy Markdown
Contributor

@int-y1 int-y1 commented Jun 15, 2023

I wrote a script to find lines that contain an odd number of backticks


Open in Gitpod

@int-y1 int-y1 added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 15, 2023
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 15, 2023
Comment on lines -938 to -939
may not have unique derivatives, in the following form. If `f : E × F → G` is `C^n+1` at `(x₀,
g(x₀))` in `(s ∪ {x₀}) × t ⊆ E × F` and `g : E → F` is `C^n` at `x₀` within some set `s ⊆ E`, then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think this is legal markdown and renders correctly; but I think this change is fine.

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 15, 2023
bors bot pushed a commit that referenced this pull request Jun 15, 2023
I wrote a script to find lines that contain an odd number of backticks
@bors
Copy link
Copy Markdown

bors bot commented Jun 15, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: fix backtick in docs [Merged by Bors] - chore: fix backtick in docs Jun 15, 2023
@bors bors bot closed this Jun 15, 2023
@bors bors bot deleted the fix-backtick branch June 15, 2023 14:40
@urkud
Copy link
Copy Markdown
Member

urkud commented Jun 15, 2023

Did you use something more advanced than this?

git grep '^\([^`]*`[^`]*`\)*`[^`]*$'  | grep -v '```'

@int-y1
Copy link
Copy Markdown
Contributor Author

int-y1 commented Jun 16, 2023

@urkud I wrote a 20-line python script

import os

def f(rootdir,pre):
    for root, subdirs, files in os.walk(rootdir):
        for fn in files:
            filepath=root+'\\'+fn
            with open(filepath) as f:
                a=pre+filepath[len(rootdir):].replace('\\','/')
                b=f.read()
                for i,s in enumerate(b.split('\n')):
                    s=s.strip()
                    if s.count('`')%2==0: continue
                    if s.count('`')==3 and '```' in s: continue
                    print(f'{a}:{i+1} {s}')

f('D:\\repo\\lean\\mathlib4\\Mathlib','Mathlib')
f('D:\\repo\\lean\\mathlib4\\test','test')
f('D:\\repo\\lean\\mathlib4\\Cache','Cache')
#f('D:\\repo\\lean\\mathlib4\\scripts','scripts')

Unfortunately, this script fetches ~1000 lines of macro code that I don't care about

alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
I wrote a script to find lines that contain an odd number of backticks
kim-em pushed a commit that referenced this pull request Jun 25, 2023
I wrote a script to find lines that contain an odd number of backticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants