Skip to content

feat: port add_decl_doc#499

Closed
lakesare wants to merge 2 commits intomasterfrom
lakesare_copy_doc_string_test
Closed

feat: port add_decl_doc#499
lakesare wants to merge 2 commits intomasterfrom
lakesare_copy_doc_string_test

Conversation

@lakesare
Copy link
Copy Markdown
Contributor

@lakesare lakesare commented Oct 24, 2022

  • Add tests for copy_doc_string and add_decl_doc
  • Remove add_decl_doc from Syntax.lean (because it's already implemented in Lean4)

@lakesare lakesare requested a review from digama0 October 24, 2022 18:24
@lakesare lakesare changed the title copy_doc_string: add automated test feat: port add_decl_doc Oct 24, 2022
@lakesare lakesare marked this pull request as draft October 27, 2022 17:05
@gebner gebner added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 31, 2022
This was referenced Nov 19, 2022
@digama0
Copy link
Copy Markdown
Member

digama0 commented Nov 21, 2022

This PR is no longer needed, as the affected commands have already been upstreamed or removed.

@digama0 digama0 closed this Nov 21, 2022
lakesare added a commit that referenced this pull request Nov 24, 2022
@int-y1 int-y1 deleted the lakesare_copy_doc_string_test branch April 16, 2023 18:21
lakesare added a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants