Skip to content

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18854#4840

Closed
j-loreaux wants to merge 9 commits intomasterfrom
port/forward-18854
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18854#4840
j-loreaux wants to merge 9 commits intomasterfrom
port/forward-18854

Conversation

@j-loreaux
Copy link
Copy Markdown
Contributor

This forward-ports all the files from leanprover-community/mathlib3#18854 which have already been ported, and it also ports the new file algebra.star.order, which is a split from algebra.star.basic and was necessary to do at the same time.


Open in Gitpod

@j-loreaux j-loreaux added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jun 8, 2023
@ChrisHughes24
Copy link
Copy Markdown
Member

thanks

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 8, 2023
@ChrisHughes24
Copy link
Copy Markdown
Member

Didn't check the build

bors r-

@ChrisHughes24
Copy link
Copy Markdown
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 8, 2023
This forward-ports all the files from leanprover-community/mathlib3#18854 which have already been ported, and it also ports the new file `algebra.star.order`, which is a split from `algebra.star.basic` and was necessary to do at the same time.



Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@eric-wieser
Copy link
Copy Markdown
Member

Is there a reason you didn't use start_port.sh here?

@bors
Copy link
Copy Markdown

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#18854 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#18854 Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/forward-18854 branch June 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants