Skip to content

[Merged by Bors] - chore: forward port leanprover-community/mathlib#19118#4831

Closed
ADedecker wants to merge 6 commits intomasterfrom
forward-port-19118
Closed

[Merged by Bors] - chore: forward port leanprover-community/mathlib#19118#4831
ADedecker wants to merge 6 commits intomasterfrom
forward-port-19118

Conversation

@ADedecker
Copy link
Copy Markdown
Member

@ADedecker ADedecker commented Jun 7, 2023

This also removes a stray import Mathlib.Tactic, which causes a downstream file to break.


Open in Gitpod

@ADedecker ADedecker added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jun 7, 2023
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 8, 2023
bors bot pushed a commit that referenced this pull request Jun 8, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jun 8, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 8, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser eric-wieser changed the title chore: forward port https://github.com/leanprover-community/mathlib/pull/19118 chore: forward port leanprover-community/mathlib#19118 Jun 8, 2023
@bors
Copy link
Copy Markdown

bors bot commented Jun 8, 2023

Build failed:

@ADedecker
Copy link
Copy Markdown
Member Author

I tried merging master to fix the build error...

@eric-wieser
Copy link
Copy Markdown
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 12, 2023
This also removes a stray `import Mathlib.Tactic`, which causes a downstream file to break.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jun 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward port leanprover-community/mathlib#19118 [Merged by Bors] - chore: forward port leanprover-community/mathlib#19118 Jun 12, 2023
@bors bors bot closed this Jun 12, 2023
@bors bors bot deleted the forward-port-19118 branch June 12, 2023 13:20
kim-em pushed a commit that referenced this pull request Jun 25, 2023
This also removes a stray `import Mathlib.Tactic`, which causes a downstream file to break.



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants