[Merged by Bors] - feat: Adjunction between topological spaces and locales#4593
Closed
[Merged by Bors] - feat: Adjunction between topological spaces and locales#4593
Conversation
…mathlib4 into frametopadjunction
…mmunity/mathlib4 into frametopadjunction
eric-wieser
reviewed
Oct 20, 2023
ocfnash
approved these changes
Oct 20, 2023
Contributor
There was a problem hiding this comment.
The suggestions are all just nitpicking / inlining / fixing non-terminal simps.
To get the suggestions to work you will need to add the following simp lemmas elsewhere:
namespace Set
variable {α : Type*}
-- Beneath `Set.setOf_true`
@[simp] theorem setOf_top : { _x : α | ⊤ } = univ := rfl
-- Beneath `Set.setOf_false`
@[simp] theorem setOf_bot : { _x : α | ⊥ } = ∅ := rfl
end Set
namespace TopologicalSpace.Opens
open Set
variable {α : Type*} [TopologicalSpace α]
-- Maybe near `TopologicalSpace.Opens.coe_top`
@[simp] theorem mk_univ : (⟨univ, isOpen_univ⟩ : Opens α) = ⊤ := rfl
-- Maybe near `TopologicalSpace.Opens.coe_bot`
@[simp] theorem mk_empty : (⟨∅, isOpen_empty⟩ : Opens α) = ⊥ := rfl
end TopologicalSpace.OpensOnce these suggestions have been made I think this is ready.
Co-authored-by: Oliver Nash <github@olivernash.org> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Co-authored-by: Oliver Nash <github@olivernash.org>
YaelDillies
reviewed
Oct 20, 2023
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
faenuccio
reviewed
Oct 20, 2023
faenuccio
reviewed
Oct 20, 2023
faenuccio
reviewed
Oct 20, 2023
faenuccio
reviewed
Oct 20, 2023
faenuccio
reviewed
Oct 20, 2023
faenuccio
reviewed
Oct 20, 2023
ocfnash
reviewed
Oct 20, 2023
Contributor
ocfnash
left a comment
There was a problem hiding this comment.
Thanks for coming back to this.
Please feel free to merge this as soon as you have addressed Filippo's suggestions and my last round of nitpicks.
bors d+
|
✌️ samvang can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
We define the contravariant functors between the categories of Frames and Topological Spaces and prove that they form an adjunction. Work started at the BIRS workshop "Formalization of Cohomology Theories", Banff, May 2023. Co-authored-by: Anne Baanen <vierkantor@vierkantor.com> Co-authored-by: leopoldmayer <leomayer@uw.edu> Co-authored-by: Brendan Seamas Murphy <shamrockfrost@gmail.com> Co-authored-by: leopoldmayer <leomayer@uw.edu> Co-authored-by: Brendan Murphy <shamrockfrost@gmail.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
We define the contravariant functors between the categories of Frames and Topological Spaces and prove that they form an adjunction. Work started at the BIRS workshop "Formalization of Cohomology Theories", Banff, May 2023. Co-authored-by: Anne Baanen <vierkantor@vierkantor.com> Co-authored-by: leopoldmayer <leomayer@uw.edu> Co-authored-by: Brendan Seamas Murphy <shamrockfrost@gmail.com> Co-authored-by: leopoldmayer <leomayer@uw.edu> Co-authored-by: Brendan Murphy <shamrockfrost@gmail.com> Co-authored-by: Vierkantor <vierkantor@vierkantor.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We define the contravariant functors between the categories of Frames and Topological Spaces and prove that they form an adjunction.
Work started at the BIRS workshop "Formalization of Cohomology Theories", Banff, May 2023.
Co-authored-by: Anne Baanen vierkantor@vierkantor.com
Co-authored-by: leopoldmayer leomayer@uw.edu
Co-authored-by: Brendan Seamas Murphy shamrockfrost@gmail.com