Skip to content

[Merged by Bors] - feat: forward-port PR 19070#4327

Closed
urkud wants to merge 1 commit intomasterfrom
forward-port-19070
Closed

[Merged by Bors] - feat: forward-port PR 19070#4327
urkud wants to merge 1 commit intomasterfrom
forward-port-19070

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented May 25, 2023

Forward-port leanprover-community/mathlib3#19070:

  • add Filter.set_eventuallyLE_iff_mem_inf_principal,
    Filter.set_eventuallyLE_iff_inf_principal_le, and
    Filter.set_eventuallyEq_iff_inf_principal;
  • golf nhdsWithin_eq_iff_eventuallyEq and nhdsWithin_le_iff.

The original PR golfs one more lemma which was already golfed to 1
line in Mathlib 4.


Open in Gitpod

Forward-port leanprover-community/mathlib3#19070:

- add `Filter.set_eventuallyLE_iff_mem_inf_principal`,
`Filter.set_eventuallyLE_iff_inf_principal_le`, and
`Filter.set_eventuallyEq_iff_inf_principal`;
- golf `nhdsWithin_eq_iff_eventuallyEq` and `nhdsWithin_le_iff`.

The original PR golfs one more lemma which was already golfed to 1
line in Mathlib 4.
@urkud urkud added awaiting-review mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels May 25, 2023
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@kim-em kim-em added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 25, 2023
bors bot pushed a commit that referenced this pull request May 25, 2023
Forward-port leanprover-community/mathlib3#19070:

- add `Filter.set_eventuallyLE_iff_mem_inf_principal`,
`Filter.set_eventuallyLE_iff_inf_principal_le`, and
`Filter.set_eventuallyEq_iff_inf_principal`;
- golf `nhdsWithin_eq_iff_eventuallyEq` and `nhdsWithin_le_iff`.

The original PR golfs one more lemma which was already golfed to 1
line in Mathlib 4.
@bors
Copy link
Copy Markdown

bors bot commented May 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: forward-port PR 19070 [Merged by Bors] - feat: forward-port PR 19070 May 25, 2023
@bors bors bot closed this May 25, 2023
@bors bors bot deleted the forward-port-19070 branch May 25, 2023 12:49
urkud added a commit that referenced this pull request May 25, 2023
The actual forward-porting was done in #4327 and #4328
bors bot pushed a commit that referenced this pull request May 25, 2023
The actual forward-porting was done in #4327 and #4328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants